New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control grid option via comment #1138
Conversation
* Add gridStatus method to Processor * Add test case * Update README.md
@fanich37 awesome! One last thing. You need to improve test. Right now tests doesn’t execute every line of code. Run:
It will show what lines was not executed |
Seems like yoou need to test |
Can you also add an It should work both ways, you can turn the setting on if you have grid disabled by default or off if you have it enabled by default. BTW, I ❤ the idea 😊 |
Oh, you did, you just didn't add it to the readme. Can you add the off command to the readme? |
@ai Sure, I'll add them 👌 But, to be honest, I don't like the behaviour of Update: I missed one thing. Now it works as expected. |
@Dan503 Sure, I'll add it in the next commit 👌 |
* Remove unused code * Update test * Update README.md
|
||
if (node.parent) { | ||
let p = node.prev() | ||
if (p && p.type === 'comment' && IGNORE_NEXT.test(p.text)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А нам нужно это? Мы же всегда вызываем disabled()
до запуска gridStatus
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Блин, выходит, что нет...
} | ||
|
||
let value = null | ||
if (node.nodes) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node
— это свойство, к которому мы ходим добавить префикс? Зачем тогда мы смотри его детей? Надо смотреть node.parent.nodes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Подозревал, что не до конца разобрался... Спасибо за ревью, Андрей 🙏
It creates |
Yes, I added it in my last commit right after I realised what it does 😃 |
@fanich37 I am writing an article about all the awesome new stuff that is in version 9.2.0. Are you happy for me to call you by the name "Andrey Alexandrov" in the article? Where would you like your name to link to? At the moment I'm linking to your GitHub account. Is there somewhere else you would prefer I link to like a personal website, your linked in profile, or your twitter profile? |
Wow! That's awesome! Of course you can call me by name. And my GitHub account is the only social thing I'm actively using😃 Thank you, Daniel🙏 |
Add gridStatus method to Processor
Add test case
Update README.md