Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for at-rules #1272

Merged
merged 1 commit into from Dec 8, 2019
Merged

Add test for at-rules #1272

merged 1 commit into from Dec 8, 2019

Conversation

gosolivs
Copy link
Member

@gosolivs gosolivs commented Dec 8, 2019

No description provided.

it('ignore prefix in vendor at rules', () => {
let input = read('at-rules')
let output = read('at-rules.out')
let result = postcss([autoprefixer({ cascade: false })]).process(input)
Copy link
Member

@ai ai Dec 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoprefixer will use current browsers and could change output in the future

Copy link
Member Author

@gosolivs gosolivs Dec 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed that.

@@ -547,6 +547,13 @@ it('works with CSS Modules', () => {
postcss([autoprefixer()]).process(':export { selectors: _1q6ho_2 }').css
})

it('ignore prefix in vendor at rules', () => {
let input = read('at-rules')
Copy link
Member

@ai ai Dec 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a shortcut to do this test. You can find it in hacks secltion in this test file.

Copy link
Member Author

@gosolivs gosolivs Dec 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed that.

body {
-webkit-appearance: none;
-moz-appearance: none;
appearance: none;
Copy link
Member

@ai ai Dec 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend enabling cascade here to make test readable and more standard

Copy link
Member Author

@gosolivs gosolivs Dec 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed that.

@ai ai merged commit 05e515e into postcss:master Dec 8, 2019
1 check passed
Dan503 pushed a commit to Dan503/autoprefixer that referenced this issue Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants