Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using unsupported PostCSS version (#361) #362

Merged

Conversation

thinkverse
Copy link
Contributor

Added the postcss version check @ai talked about. Changed the wording a bit and used the built-in error function.

As for testing this functionality, not going to lie. I couldn't get this error to throw ones, even did the steps mentioned in the issue (#361) by using npm link to this version and installing plugins that use PostCSS 7 and it builds the CSS file and didn't throw a single error.

Seems like this error might be thrown very rarely? But I do hope it helps in the long run. 馃檪

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.41% when pulling e140a29 on thinkverse:unsupported-postcss-version-error into 4b9b66d on postcss:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.41% when pulling e140a29 on thinkverse:unsupported-postcss-version-error into 4b9b66d on postcss:master.

index.js Show resolved Hide resolved
@ai
Copy link
Member

ai commented Dec 7, 2020

@RyanZim this PR is ready to merge. My yarn/npm error message suggestion is not a blocker to merge and release it (especially since a lot of users have this problem right now).

@thinkverse
Copy link
Contributor Author

I tried to find a good solution to the auto-discovery of the package manager but to no avail. Could keep looking for a solution for a later PR though of the feature is really needed.

@RyanZim
Copy link
Collaborator

RyanZim commented Dec 8, 2020

KISS; no need for any fancy auto-detection. LGTM

@RyanZim RyanZim merged commit 96b6521 into postcss:master Dec 8, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants