Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dir-dependency messages #383

Merged
merged 5 commits into from Jun 14, 2021

Conversation

bradlc
Copy link
Contributor

@bradlc bradlc commented May 17, 2021

This PR adds support for dir-dependency messages.

Directory dependencies are added to the dependency graph in the same way that files are. Chokidar accepts directories and will watch them recursively. Then, when a file changes we determine the "recompile" list by finding the dependants of each of the files ancestor directories.

Any questions or concerns let me know 馃憤

@coveralls
Copy link

coveralls commented May 17, 2021

Coverage Status

Coverage decreased (-5.2%) to 76.19% when pulling 57a2ef4 on bradlc:dir-dependency into ab73f36 on postcss:master.

Copy link
Collaborator

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry so long in getting around to reviewing this; time flies.

This needs tests, also one nitpick.

index.js Outdated Show resolved Hide resolved
@bradlc
Copy link
Contributor Author

bradlc commented Jun 1, 2021

No problem @RyanZim, thanks for taking a look! I have added some tests now 馃憤

@RyanZim RyanZim merged commit f0e262e into postcss:master Jun 14, 2021
1 of 2 checks passed
1st8 added a commit to 1st8/postcss-cli that referenced this pull request Aug 27, 2021
This extends postcss#383 to pass glob information on to chokidar, with the intention of reducing outputs when unrelated files are modified
RyanZim pushed a commit that referenced this pull request Sep 23, 2021
This extends #383 to pass glob information on to chokidar, with the intention of reducing outputs when unrelated files are modified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants