New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and fix for upstream css-color-function bug #33

Merged
merged 4 commits into from Oct 10, 2017

Conversation

Projects
None yet
3 participants
@tylergaw
Contributor

tylergaw commented Jan 10, 2017

Ready for merge

Update 2017-10-09:
css-color-function@1.3.3 Includes the tint/shade/contrast bug fix. This PR points to that tag now. Can ignore pretty much everything below.

This PR points to my fork the 1.3.1 tag of css-color-function, so I'm guessing you'd want to wait until the npm package is updated, but wanted to go ahead and get the work in.

Currently, there's a bug in css-color-function when using the tint, shade, and contrast adjusters along with the alpha adjuster. This is due to it's use of the mix function in the Color package it's using.

I have a PR in for the fix there and added more detailed around the problem and solution ianstormtaylor/css-color-function#26

This PR adds tests for the issues and I pushed one failure up so you can see what happens: https://travis-ci.org/tylergaw/postcss-color-function/builds/190518140

For now, I'm just pointing to my fork of css color function to see the code working/tests passing: https://travis-ci.org/tylergaw/postcss-color-function/builds/190518745

Once PR 26 gets merged I can update the dep here to use the og package.

Update 2017-07-15
We merged PR/26 over in css-color-function and created a 1.3.1 tag, but have not yet published it to NPM.

This PR now points to Ian's og repo, directly to #1.3.1

@MoOx

This comment has been minimized.

Contributor

MoOx commented Feb 1, 2017

Waiting for a merge upstream.

@tylergaw tylergaw force-pushed the tylergaw:tint-shade-contrast-w-alpha-fix branch from 6a8c02f to 9df3b41 Jul 15, 2017

@tylergaw tylergaw force-pushed the tylergaw:tint-shade-contrast-w-alpha-fix branch from 9df3b41 to b0ecaba Jul 15, 2017

@tylergaw

This comment has been minimized.

Contributor

tylergaw commented Jul 15, 2017

@MoOx Pushed up a change to point to Ian's repo / #1.3.1 tag. We have push access there now. Just pointing to the tag right now until the npm package is updated.

@jonathantneal

This comment has been minimized.

Member

jonathantneal commented Oct 6, 2017

I see css-color-function has been updated to 1.3.1 on npm. Is this safe to merge now, @tylergaw ?

@jonathantneal

This comment has been minimized.

Member

jonathantneal commented Oct 9, 2017

I’m confused. @tylergaw, regardless of the name (color vs color-mod), will these other fixes (breaking changes) make it into this PR?

@tylergaw

This comment has been minimized.

Contributor

tylergaw commented Oct 9, 2017

@jonathantneal Yeah, things bounced around a bit. I updated the description here. css-color-function 1.3.3 includes the fixes for the tint/shade adjusters and is backward compatible.

There was a bit of a bump in versioning/breaking changes over there that you can read about in ianstormtaylor/css-color-function#34.

I think this PR is ready to go with 1.3.3.

@jonathantneal jonathantneal merged commit 8b222f6 into postcss:master Oct 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tylergaw tylergaw deleted the tylergaw:tint-shade-contrast-w-alpha-fix branch May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment