-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postcss-easy-import #145
Comments
? Idea is solid. 👍 |
@ben-eb No, no. I mean plugin with a few new options which will be wrap postcss-import postcssPackImport({
partial: false,
extensions: ['.css'],
glob: true
}) |
Sounds weird and will create confusion imo. |
@MoOx postcss-import can be strict and spec followed but with extending ability. postcss-pack-import (or another name) will use postcss-import as a dependency and realise scss-like features without any complications. Just for lazy people. |
Modularity celebration :) |
I get your point, but most people are lazy. |
Make sense. /cc @jonathantneal |
Nice, can you make a PR to README and add a comment/link in 8.0 CHANGELOG section so we can close this issue? |
First, great work @TrySound! So, this is a wrapper to give postcss-import the functionality of postcss-partial-import? Honest question, if we could just refactor postcss-import, would the functionality belong in a separate plugin? PostCSS partial import was only created for PreCSS compatibility. I did not like the idea of (and I accept all the flack for) creating a separate plugin for nearly the same functionality. |
postcss-import is simple and powerful api with "all we need" defaults. easy-import just gives extra very specific functionality. Powerful of modularity :) |
Why should this sugar be in its own repo? I don’t like there being 3 repos now. For instance, postcss-import does sluething to resolve the path of an |
@jonathantneal You are right. But it's simple resolver and common usable stuff. And easy-import includes all postcss-import features like media queries and plugins option for linting |
@jonathantneal |
This thing is done, so closing. |
Could we consider bringing some of this functionality back in? I think globbing is a very useful and popular addition. cc @RyanZim |
@simonsmith First, this won't happen in v9.0.0; it's long overdue for release. Hope that gets out in the next few days. Second, this is highly bikeshedable. Perhaps you can open a new issue outlining some of your thoughts; when consensus is reached, we can proceed to implement. |
Who want to get access to this? |
@TrySound I hardly have time; @simonsmith, you feel like trying? |
If @TrySound is happy to let others contribute to I'd be happy to help merge the outstanding PR and have a look at the remaining issues. |
@simonsmith Go for it! |
For reference just published |
postcss-easy-import
What if we will create pack around
postcss-import
with many optional things likeprefix
,extensions
,glob
etc.How it could be named?
Options:
prefix
Type:
String
Default:
_
Add before imported filename.
@import "dir/partial"
will look fordir/_partial.css
withprefix: '_'
extensions
Type:
Array
orString
Default:
.css
glob
Type:
Boolean
Default:
false
The text was updated successfully, but these errors were encountered: