Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added postcss-viewport-height-correction #1323

Merged
merged 4 commits into from Feb 8, 2020
Merged

Conversation

@Faisal-Manzer
Copy link
Contributor

Faisal-Manzer commented Feb 5, 2020

postcss-viewport-height-correction solves the popular problem when 100vh doesn’t fit the mobile browser screen.

postcss-viewport-height-correction solves the popular problem when 100vh doesn’t fit the mobile browser screen.
@@ -450,7 +450,7 @@ See also plugins in modular minifier [`cssnano`].
* [`stylefmt`] modern CSS formatter that works well with `stylelint`.
* [`postcss-autocorrect`] corrects typos and notifies in the console.
* [`postcss-px-to-viewport`] generates viewport units (`vw`, `vh`, `vmin`, `vmax`) from `px` units.

* [`postcss-viewport-height-correction`] solves the popular problem when 100vh doesn’t fit the mobile browser screen.

This comment has been minimized.

Copy link
@ai

ai Feb 5, 2020

Member
  1. 100vh should be as a code:
`100vh`
  1. You need to keep lines in 80 symbols long.

This comment has been minimized.

Copy link
@Faisal-Manzer

Faisal-Manzer Feb 5, 2020

Author Contributor

Corrected docs according to the recommendation

@@ -450,7 +450,7 @@ See also plugins in modular minifier [`cssnano`].
* [`stylefmt`] modern CSS formatter that works well with `stylelint`.
* [`postcss-autocorrect`] corrects typos and notifies in the console.
* [`postcss-px-to-viewport`] generates viewport units (`vw`, `vh`, `vmin`, `vmax`) from `px` units.

* [`postcss-viewport-height-correction`] "corrects" `100vh` which doesn’t fit the mobile browser screen.

This comment has been minimized.

Copy link
@ai

ai Feb 5, 2020

Member

Let’s avoid quoted "corrects". User will not understand why it is not normal correct. You can use old description, just split it into two lines.

This comment has been minimized.

Copy link
@Faisal-Manzer

Faisal-Manzer Feb 5, 2020

Author Contributor

Does splitting mean? In markdown file or in markdown preview?

This comment has been minimized.

Copy link
@ai

ai Feb 6, 2020

Member
A B
A
B
@Faisal-Manzer Faisal-Manzer requested a review from ai Feb 8, 2020
@ai ai merged commit ee267d5 into postcss:master Feb 8, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.