Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return correct column on missed semicolon #1618

Merged
merged 1 commit into from Jul 21, 2021
Merged

Return correct column on missed semicolon #1618

merged 1 commit into from Jul 21, 2021

Conversation

@Gusted
Copy link
Contributor

@Gusted Gusted commented Jul 21, 2021

I've added some test-cases to ensure it works.
Also added a comment about why we it need to get token[3]+1

And ultimately it resolves #1617

Regards,
Gusted

I've added some test-cases to ensure it works.
Also added a comment about `why` we it need to get token[3]+1

And ultimately it resolves #1617

Regards,
Gusted
@ai ai merged commit c72594b into postcss:main Jul 21, 2021
5 checks passed
5 checks passed
@github-actions
Node.js 16 Full
Details
@github-actions
Node.js 14 Quick
Details
@github-actions
Node.js 12 Quick
Details
@github-actions
Node.js 10 Quick
Details
@github-actions
Windows Quick
Details
@Gusted Gusted deleted the Gusted:fix-missed-semicolon branch Jul 21, 2021
@ai
Copy link
Member

@ai ai commented Jul 21, 2021

Thanks. I will release it today.

@Gusted
Copy link
Contributor Author

@Gusted Gusted commented Jul 21, 2021

Thank you for merging and your time.

@ai
Copy link
Member

@ai ai commented Jul 21, 2021

Released in 8.3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants