New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rollup-plugin-postcss #666

Merged
merged 2 commits into from Dec 8, 2015

Conversation

Projects
None yet
3 participants
@egoist
Contributor

egoist commented Dec 8, 2015

No description provided.

EGOIST
@egoist

This comment has been minimized.

Contributor

egoist commented Dec 8, 2015

well, Rollup is considered typo...

fix spellcheck
add Rollup to dictionary
@TrySound

This comment has been minimized.

Member

TrySound commented Dec 8, 2015

@egoist You shouldn't use sync postcss api. It's only for debug. You should use promises which could be returned in transform method.

@egoist

This comment has been minimized.

Contributor

egoist commented Dec 8, 2015

gotcha.

@egoist egoist closed this Dec 8, 2015

@egoist

This comment has been minimized.

Contributor

egoist commented Dec 8, 2015

Now using the Promise.

@egoist egoist reopened this Dec 8, 2015

@TrySound

This comment has been minimized.

Member

TrySound commented Dec 8, 2015

@egoist postcss own return promise. You don't need to wrap it in new one.

@egoist

This comment has been minimized.

Contributor

egoist commented Dec 8, 2015

@TrySound 😂 sorry for that, fixed.

@TrySound

This comment has been minimized.

Member

TrySound commented Dec 8, 2015

@egoist Can you show some real world usage example?

ai added a commit that referenced this pull request Dec 8, 2015

Merge pull request #666 from egoist/patch-1
add rollup-plugin-postcss

@ai ai merged commit 764c926 into postcss:master Dec 8, 2015

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@egoist

This comment has been minimized.

Contributor

egoist commented Dec 8, 2015

@TrySound sure, later I'll add some to that repo.

@ai

This comment has been minimized.

Member

ai commented Dec 8, 2015

@egoist sorry, I will compress Rollup link to one line (like Grunt or Brunch) because it is not so popular yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment