Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add discrete frechet distance #120
This does not appear to be well guarded for lower versions.
If I compiled against GEOS 3.6.1 I get a compile error:
lwgeom_geos.o:lwgeom_geos.c:(.text+0x6a3): undefined reference to `GEOSFrechetDistance'
Also not clear why you removed the function with the 3rd proto (densfrac), What @strk meant is you keep that one but mark the last argument as optional.
Take a look at ST_Subdivide as an example that does this:
Looking at our docu it seems people are not correctly flagging optional args in documentation so took me sometime to find a good example you can follow.
I was thinking of NULL as a value, but I think it would be cleaner to use a non NULL value for 3rd arg, so you can keep the function marked as STRICT to save cycles.