New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ST_RemoveRepeatedPoints dropping one extra point in certain ptarrays #182

Closed
wants to merge 1 commit into
base: svn-trunk
from

Conversation

Projects
None yet
2 participants
@Algunenano
Member

Algunenano commented Jan 4, 2018

No description provided.

@Algunenano

This comment has been minimized.

Member

Algunenano commented Jan 4, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 4, 2018

Codecov Report

Merging #182 into svn-trunk will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##           svn-trunk     #182      +/-   ##
=============================================
+ Coverage      79.22%   79.22%   +<.01%     
=============================================
  Files            202      202              
  Lines          63011    63016       +5     
=============================================
+ Hits           49921    49926       +5     
  Misses         13090    13090
Impacted Files Coverage Δ
liblwgeom/cunit/cu_algorithm.c 99.11% <100%> (ø) ⬆️
liblwgeom/ptarray.c 91.6% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176b60b...ce8dceb. Read the comment docs.

@Komzpa

Komzpa approved these changes Jan 5, 2018

lwgeom_free(g);
lwfree(ewkt);
g = lwgeom_from_wkt("POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))", LW_PARSER_CHECK_NONE);

This comment has been minimized.

@Komzpa

Komzpa Jan 5, 2018

Member

formatting is off a bit here

double dsq = FLT_MAX;
/* No-op on short inputs */
if ( n_points <= 2 ) return;
if ( n_points <= min_points ) return;

This comment has been minimized.

@Komzpa

Komzpa Jan 5, 2018

Member

👍

@Komzpa Komzpa added the needs NEWS label Jan 5, 2018

@Algunenano

This comment has been minimized.

Member

Algunenano commented Jan 5, 2018

Fixing the indentation issue (sorry).

About the NEWS: This is a fix for https://trac.osgeo.org/postgis/ticket/3877 but that doesn't have NEWs. Also I'm not sure if you want to announce a fix to something that hasn't been released.

@Komzpa Komzpa added to merge and removed needs NEWS labels Jan 5, 2018

@strk strk closed this in b3deaf9 Jan 5, 2018

Algunenano added a commit to Algunenano/postgis that referenced this pull request Jan 5, 2018

Fix ST_RemoveRepeatedPoints dropping one extra point in certain ptarrays
Patch by Raúl Marín Rodríguez.

Closes #3969
Closes postgis#182

git-svn-id: http://svn.osgeo.org/postgis/trunk@16221 b70326c6-7e19-0410-871a-916f4a2858ee

Algunenano added a commit to CartoDB/postgis that referenced this pull request Jan 8, 2018

Fix ST_RemoveRepeatedPoints dropping one extra point in certain ptarrays
Patch by Raúl Marín Rodríguez.

Closes #3969
Closes postgis#182

git-svn-id: http://svn.osgeo.org/postgis/trunk@16221 b70326c6-7e19-0410-871a-916f4a2858ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment