New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ST_AsText : adding optional argument 'precision' #194

Closed
wants to merge 9 commits into
base: svn-trunk
from

Conversation

Projects
None yet
4 participants
@Komzpa
Member

Komzpa commented Jan 17, 2018

This is rebase of #94.
Ticket: https://trac.osgeo.org/postgis/ticket/3986

@codecov

This comment has been minimized.

codecov bot commented Jan 17, 2018

Codecov Report

Merging #194 into svn-trunk will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##           svn-trunk     #194      +/-   ##
=============================================
- Coverage      79.32%   79.31%   -0.01%     
=============================================
  Files            201      201              
  Lines          62839    63067     +228     
=============================================
+ Hits           49844    50020     +176     
- Misses         12995    13047      +52
Impacted Files Coverage Δ
postgis/lwgeom_ogc.c 93.19% <100%> (+0.03%) ⬆️
liblwgeom/lwin_wkt_parse.c 72.83% <0%> (+5.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a738cc...cb35677. Read the comment docs.

@Komzpa

This comment has been minimized.

Member

Komzpa commented Jan 17, 2018

@dbaston @vesnikos @mwtoews please take another look and wave when you think it's on to commit.

</funcprototype>
</funcsynopsis>
</refsynopsisdiv>
<refsection>
<title>Description</title>
<para>Returns the Well-Known Text representation of the geometry/geography.</para>
<para>Returns the Well-Known Text representation of the geometry/geography. Optional argument may be used to reduce the maximum number

This comment has been minimized.

@dbaston

dbaston Jan 17, 2018

Member

Consider defaulting to 18, because people use WKT as an archive and storage format (even though the docs warn them not to).

This comment has been minimized.

@dbaston

dbaston Jan 17, 2018

Member

Or tap into extra_float_digits for consistency with pg_dump etc

This comment has been minimized.

@mwtoews

mwtoews Jan 18, 2018

See Trac#407 for the discussion of extra_float_digits.

</funcprototype>
</funcsynopsis>
</refsynopsisdiv>
<refsection>
<title>Description</title>
<para>Returns the Well-Known Text representation of the geometry/geography.</para>
<para>Returns the Well-Known Text representation of the geometry/geography. Optional argument may be used to reduce the maximum number

This comment has been minimized.

@dbaston

dbaston Jan 17, 2018

Member

Define precision as # digits after decimal point

@@ -952,12 +962,12 @@ SELECT (ST_AsLatLonText('POINT (-302.2342342 -792.32498)'));
</note>
<para>Availability: 1.5 - support for geography was introduced.</para>
<para>Enhanced: 2.3 - optional parameter precision introduced.</para>

This comment has been minimized.

@dbaston

dbaston Jan 17, 2018

Member

2.5, I think?

current_database() AS f_table_catalog,
n.nspname AS f_table_schema,
c.relname AS f_table_name,
current_database() AS f_table_catalog,

This comment has been minimized.

@dbaston

dbaston Jan 17, 2018

Member

Remove formatting changes

@@ -4793,6 +4793,13 @@ CREATE OR REPLACE FUNCTION ST_AsText(geometry)
LANGUAGE 'c' IMMUTABLE STRICT _PARALLEL
COST 750; --guess
-- Availability: 2.3.0

This comment has been minimized.

@dbaston

dbaston Jan 17, 2018

Member

2.5.0

@strk

strk approved these changes Jan 18, 2018

good job!

Komzpa added some commits Jan 18, 2018

@strk strk closed this in 5a45394 Jan 18, 2018

@Komzpa Komzpa deleted the Komzpa:st_astext_opt branch Jan 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment