New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in iterate_4d #196

Closed
wants to merge 1 commit into
base: svn-trunk
from

Conversation

Projects
None yet
1 participant
@Algunenano
Member

Algunenano commented Jan 19, 2018

Appeared with:
do_median_test("MULTIPOINT ZM ((0 -1 0 1), (0 0 0 1), (0 1 0 0.5), (0 1 0 0.5))", "POINT (0 0 0)", LW_TRUE, 1000);

lwgeom_median.c:111:17: runtime error: division by zero

Introduced in #176

Fix bug in iterate_4d
Appeared with:
do_median_test("MULTIPOINT ZM ((0 -1 0 1), (0 0 0 1), (0 1 0 0.5), (0 1 0 0.5))", "POINT (0 0 0)", LW_TRUE, 1000);

lwgeom_median.c:111:17: runtime error: division by zero
@Algunenano

This comment has been minimized.

Member

Algunenano commented Jan 19, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 19, 2018

Codecov Report

Merging #196 into svn-trunk will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           svn-trunk     #196   +/-   ##
==========================================
  Coverage      79.32%   79.32%           
==========================================
  Files            201      201           
  Lines          62841    62841           
==========================================
  Hits           49846    49846           
  Misses         12995    12995
Impacted Files Coverage Δ
liblwgeom/lwgeom_median.c 97.16% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 440f411...e1f3836. Read the comment docs.

@strk strk closed this in 7f64577 Jan 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment