New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_gdal: Don't assume failure when the datapath is invalid #206

Closed
wants to merge 1 commit into
base: svn-trunk
from

Conversation

Projects
None yet
1 participant
@Algunenano
Member

Algunenano commented Feb 6, 2018

From gdal cpl_findfile.cpp (https://git.io/vAebm) if GDAL_DATA is not found some system folders can be used to look for resources, so the check might not fail due to unsetting it.

Trac issue: https://trac.osgeo.org/postgis/ticket/4013

@Algunenano Algunenano changed the title from check_gdal: Don't assume failute when the datapath is invalid to check_gdal: Don't assume failure when the datapath is invalid Feb 6, 2018

check_gdal: Don't assume failure when the datapath is invalid
From gdal cpl_findfile.cpp (https://git.io/vAebm) if GDAL_DATA
is not found some system folders can be used to look for resources,
so the check might not fail due to unsetting it.
@codecov

This comment has been minimized.

codecov bot commented Feb 9, 2018

Codecov Report

Merging #206 into svn-trunk will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           svn-trunk     #206      +/-   ##
=============================================
- Coverage      79.34%   79.33%   -0.02%     
=============================================
  Files            201      201              
  Lines          62968    62968              
=============================================
- Hits           49960    49953       -7     
- Misses         13008    13015       +7
Impacted Files Coverage Δ
raster/rt_pg/rtpg_utility.c 70.58% <0%> (-11.77%) ⬇️
raster/rt_core/rt_util.c 82.22% <0%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5131a96...5b8bbf2. Read the comment docs.

@strk strk closed this in 829c816 Feb 13, 2018

Algunenano added a commit to Algunenano/postgis that referenced this pull request May 18, 2018

check_gdal: Don't assume failure when the datapath is invalid
Patch by Raúl Marín Rodríguez

Closes postgis#206
Closes #4013


git-svn-id: http://svn.osgeo.org/postgis/trunk@16378 b70326c6-7e19-0410-871a-916f4a2858ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment