New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address warnings across liblwgeom/ and postgis/ #207

Closed
wants to merge 2 commits into
base: svn-trunk
from

Conversation

Projects
None yet
2 participants
@Algunenano
Member

Algunenano commented Feb 7, 2018

@@ -166,7 +166,7 @@ static void down(MINHEAP *tree,areanode *arealist,int parent)
Sift Up
*/
static void up(MINHEAP *tree,areanode *arealist,int c)
static void up(MINHEAP *tree, __attribute__((__unused__)) areanode *e,int c)

This comment has been minimized.

@dbaston

dbaston Feb 7, 2018

Member

Is this portable?

@Algunenano

This comment has been minimized.

Member

Algunenano commented Feb 7, 2018

The main header defines it if not available (

# define __attribute__(x)
).

@codecov

This comment has been minimized.

codecov bot commented Feb 9, 2018

Codecov Report

Merging #207 into svn-trunk will decrease coverage by 0.01%.
The diff coverage is 64.7%.

Impacted file tree graph

@@              Coverage Diff              @@
##           svn-trunk     #207      +/-   ##
=============================================
- Coverage      79.34%   79.32%   -0.02%     
=============================================
  Files            201      201              
  Lines          62968    63199     +231     
=============================================
+ Hits           49960    50135     +175     
- Misses         13008    13064      +56
Impacted Files Coverage Δ
liblwgeom/lwin_wkt_parse.c 72.83% <ø> (+5.24%) ⬆️
postgis/gserialized_estimate.c 77.9% <ø> (ø) ⬆️
postgis/lwgeom_functions_basic.c 80.88% <ø> (ø) ⬆️
liblwgeom/lwgeodetic_tree.c 90.64% <ø> (ø) ⬆️
liblwgeom/measures.c 84.82% <0%> (-0.37%) ⬇️
postgis/lwgeom_in_geohash.c 89.58% <0%> (ø) ⬆️
liblwgeom/lwgeom_topo.c 61.52% <0%> (ø) ⬆️
postgis/lwgeom_accum.c 86.76% <100%> (ø) ⬆️
liblwgeom/lwprint.c 95.63% <100%> (ø) ⬆️
postgis/lwgeom_in_gml.c 96.94% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5131a96...10c97b0. Read the comment docs.

@strk strk closed this in 8a78bf0 Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment