New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtpg_wkb: Add missing include #211

Closed
wants to merge 1 commit into
base: svn-trunk
from

Conversation

Projects
None yet
4 participants
@Algunenano
Member

Algunenano commented Feb 20, 2018

No description provided.

@Komzpa

This comment has been minimized.

Member

Komzpa commented Feb 20, 2018

@Algunenano

This comment has been minimized.

Member

Algunenano commented Feb 20, 2018

Yes, it was introduced in https://trac.osgeo.org/postgis/ticket/2221 and I'm just waiting for the test to pass.

@strk strk closed this in 1d78934 Feb 20, 2018

@Komzpa

This comment has been minimized.

Member

Komzpa commented Feb 20, 2018

Thanks! CI passed, patch committed :)

@dustymugs

This comment has been minimized.

Contributor

dustymugs commented Feb 20, 2018

How odd. Nothing about rtpg_wkb.c requires lwgeom...

@Algunenano

This comment has been minimized.

Member

Algunenano commented Feb 20, 2018

RASTER_fromHexWKB uses text2cstring.

@dustymugs

This comment has been minimized.

Contributor

dustymugs commented Feb 20, 2018

Yep. I see that. That wasn't intended. Should have been using text_to_cstring instead.

@pramsey

This comment has been minimized.

Member

pramsey commented Feb 20, 2018

There's no particular reason we couldn't strip out our implementation. I cannot recall if I put it in because there was no text_to_cstring at the time, or because I just didn't find it in the pgsql code base.

@Algunenano

This comment has been minimized.

Member

Algunenano commented Feb 20, 2018

There's no particular reason we couldn't strip out our implementation. I cannot recall if I put it in because there was no text_to_cstring at the time, or because I just didn't find it in the pgsql code base.

I've made a quick test and found there is at least issues with lwgeom_in_geojson.c as both Postgres utils/builtins.h and LibJSON json-c/json.h declare json_object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment