Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homogenize, format and remove some dead code in lwgeom_geos.c #215

Closed
wants to merge 1 commit into
base: svn-trunk
from

Conversation

Projects
None yet
3 participants
@Komzpa
Copy link
Member

Komzpa commented Feb 20, 2018

No description provided.

@pramsey

This comment has been minimized.

Copy link
Member

pramsey commented Feb 20, 2018

What's in here other than a formatting pass?

@Komzpa

This comment has been minimized.

Copy link
Member Author

Komzpa commented Feb 20, 2018

It is formatting / minor changes (1 -> LW_TRUE) only, before more substantial changes.

@strk strk closed this in 369d4a8 Feb 20, 2018

{
lwgeom_geos_errmsg[LWGEOM_GEOS_ERRMSG_MAXSIZE-1] = '\0';
}
if (LWGEOM_GEOS_ERRMSG_MAXSIZE - 1 < vsnprintf(lwgeom_geos_errmsg, LWGEOM_GEOS_ERRMSG_MAXSIZE - 1, fmt, ap))

This comment has been minimized.

@dbaston

dbaston Feb 20, 2018

Member

Why are you removing braces?

This comment has been minimized.

@pramsey

pramsey Feb 20, 2018

Member

Yeah, there is quite some opinionated re-styling here. The "good neighbour" style policy is to try to ape what's already there, little though you make like it, rather than bringing everything into line w/ your own personal preferences.

This comment has been minimized.

@dbaston

dbaston Feb 21, 2018

Member

@Komzpa can you comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.