New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOS ClipByBox2D notice #239

Closed
wants to merge 1 commit into
base: svn-trunk
from

Conversation

Projects
None yet
2 participants
@Komzpa
Member

Komzpa commented Apr 24, 2018

No description provided.

@Komzpa

This comment has been minimized.

Member

Komzpa commented Apr 24, 2018

@strk strk closed this in bb73e66 Apr 24, 2018

geometry is not guaranteed to be valid (self-intersections for a polygon
may be introduced). Topologically invalid input geometries do not result
in exceptions being thrown.
Clips a geometry by a 2D box. The output geometry is not guaranteed to be valid

This comment has been minimized.

@dbaston

dbaston Apr 24, 2018

Member

Is this still accurate?

This comment has been minimized.

@Komzpa

Komzpa Apr 24, 2018

Member

it is not guaranteed but happens to be valid.

/* This lwgeom_intersection should be a call to GEOSClipByRect:
* g3 = GEOSClipByRect(g1, x1, y1, x2, y2);
* Unfortunately as of GEOS 3.7 it chokes on practical inputs.

This comment has been minimized.

@dbaston

dbaston Apr 24, 2018

Member

GEOS 3.7 is not released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment