New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address compiler warnings (-Wall -Wextra) #246

Closed
wants to merge 6 commits into
base: svn-trunk
from

Conversation

Projects
None yet
2 participants
@Algunenano
Member

Algunenano commented May 21, 2018

Algunenano added some commits May 21, 2018

Address clang warnings
clang version 6.0.0 (tags/RELEASE_600/final)
Address gcc warnings
gcc (GCC) 8.1.0
@Komzpa

This comment has been minimized.

Member

Komzpa commented May 21, 2018

can we also get a -Wall -Wextra line in travis.yml? :)

@Algunenano

This comment has been minimized.

Member

Algunenano commented May 21, 2018

I've added -Wextra to travis but removed -Wunused-parameter for now since, at least with my PG installation, it will alert of PG_FUNCTION_ARGS being unused in a bunch of functions but, up to my knowledge, it's mandatory. The way to avoid those warnings would be with __attribute__((unused)) or some other compiler dependent macro.

@strk strk closed this in e85cfe5 May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment