New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ST_PointOnSurface -> liblwgeom #257

Closed
wants to merge 4 commits into
base: svn-trunk
from

Conversation

Projects
None yet
3 participants
@Komzpa
Member

Komzpa commented Jun 5, 2018

No description provided.

Komzpa added some commits Jun 5, 2018

GEOSGeometry *g1v;
lwnotice("%s: GEOS Error: %s", __func__, lwgeom_geos_errmsg);
if (!GEOSisValid(g1))

This comment has been minimized.

@dbaston

dbaston Jun 5, 2018

Member

It would really be good to complete the discussion on this issue with the project team before continuing to make changes like this.

This comment has been minimized.

@pramsey

pramsey Jun 5, 2018

Member

Concur, we have long shied away from automagically fixing people's geometry.

@@ -543,7 +543,7 @@ output_geos_as_lwgeom(GEOSGeometry** g, LWGEOM** geom, const int32_t srid, const
return LW_TRUE;
}
/* Output encoder and sanity checker for GEOS wrappers */
/* Clean up and return NULL */
inline static LWGEOM*
geos_clean_and_fail(GEOSGeometry* g1, GEOSGeometry* g2, GEOSGeometry* g3, const char* funcname)

This comment has been minimized.

@dbaston

dbaston Jun 5, 2018

Member

What do you think about making these macros? It would avoid the awkwardness of passing __func__ around everywhere.

@strk strk closed this in 1277c75 Jun 5, 2018

@Komzpa Komzpa deleted the Komzpa:pointonsurface-lwgeom branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment