New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert lwgeom_clip_by_rect changes #282

Closed
wants to merge 3 commits into
base: svn-trunk
from

Conversation

Projects
None yet
2 participants
@dbaston
Member

dbaston commented Aug 1, 2018

This PR reverts lwgeom_clip_by_rect to its implementation in PostGIS 2.2 - 2.4.

It makes trivial modifications to the MVT tests to reflect the different results returned by GEOSClipByRect instead of GEOSIntersection. The changed results are topologically equivalent to the previous results, and their orientation is unchanged.

No tests have been commented out or made version-dependent.

@dbaston

This comment has been minimized.

Show comment
Hide comment
@dbaston

dbaston Aug 1, 2018

Member

Note that Travis failure is from a compiler warning in third-party code.

Member

dbaston commented Aug 1, 2018

Note that Travis failure is from a compiler warning in third-party code.

@Algunenano

👍 I'll have a look at the warning separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment