Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GiST and SP-GiST n-D indexes (based on GIDX) with overlaps, contains, within, and equals operators #293

Closed
wants to merge 11 commits into from

Conversation

@estebanzimanyi
Copy link

commented Sep 11, 2018

The current version of PostGIS provides GiST n-D indexes (based on GIDX) only with the &&& (overlaps) operator. This PR extends the GiST n-D indexes for three additional operators: ~~ (contains) @@ (within) ~~= (equals). It also implements SP-GiST n-D indexes that support these four operators.

@Komzpa

This comment has been minimized.

Copy link
Member

commented Sep 11, 2018

@estebanzimanyi I committed support for PG11 on Travis, if you pull it in we'll have the tests actually run :)

@alesuiss

This comment has been minimized.

Copy link

commented Sep 11, 2018

N.b. that there is still some instability in the results for GiST n-D indexes (cf. ticket #4139)

EDIT: the failing test case on Travis is due to that bug, which is present in stock postgis

@Komzpa

This comment has been minimized.

Copy link
Member

commented Sep 14, 2018

@alesuiss may I ask you to split this into two parts then, so we can merge it easier?

a green one with sp-gist comparing itself to non-indexed scan, and a failing to-fix one exposing the bug in gist? this can probably be achived by temporarily commenting out failing gist test.

Arthur Lesuisse added 3 commits Sep 14, 2018
Arthur Lesuisse
Arthur Lesuisse
@alesuiss

This comment has been minimized.

Copy link

commented Sep 14, 2018

I guess the coverage issue is because we started from an earlier version of svn-trunk. Do we need to do something about that?

@Komzpa Komzpa referenced this pull request Nov 10, 2018

@strk strk closed this in 2f3f798 Nov 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.