Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impose minimum number of segments per arc during linearization #320

Closed
wants to merge 5 commits into from

Conversation

@dbaston
Copy link
Member

commented Oct 26, 2018

This PR implements fixed limits of 2 segments per non-circular arc and 3 segments per circular arc, following the discussion in Trac #3719.

The only logical changes are in 548fd5d; the preceding commits attempt to clarify some code but do not change any logic.

dbaston added 5 commits Oct 25, 2018
Pull some code out of lwarc_linearize into separate functions
This commit does not change any logic; it just attempts to make
lwarc_linearize more readable.
Impose a minimum of 2-3 segments when linearizing an arc
Update existing test cases to match new behavior.

References #3719
@Komzpa

This comment has been minimized.

Copy link
Member

commented Oct 30, 2018

@dbaston how about getting this merged?

@dbaston

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2018

@Komzpa I'd like to give the make sure the ticket author has an opportunity to check it out. Is there a hurry?

@Komzpa

This comment has been minimized.

Copy link
Member

commented Oct 31, 2018

Hi,

6 days ago the original ticket author had no way to know about this PR. Pinging things to get them moving on github is my duty :)

It passes tests, passes coverage, and if it's covering the issues mentioned by ticket author - I'd say we just merge it and close ticket. If there are some more issues, that would deserve a new ticket.

If you're planning to backport it, 2.5.1 is in a few weeks according to @robe2's email.

@dbaston

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2018

I don't plan to backport it because it's a behavior change. I'll merge it when I'm ready to merge it.

@giohappy

This comment has been minimized.

Copy link

commented Nov 8, 2018

@dbaston we can proceed with merge

@strk strk closed this in b6eb7ec Nov 8, 2018

@dbaston

This comment has been minimized.

Copy link
Member Author

commented Dec 19, 2018

@strk @robe2 @pramsey Do you have any thoughts about backporting the changes included in this PR to 2.5.x? On the one hand, they include a behavior change -- I had to change several test results -- but on the other hand, they fix a reported bug, and it's hard to imagine a case where the older behavior (linearizing an arc with a single straight line) is desirable.

@pramsey

This comment has been minimized.

Copy link
Member

commented Dec 19, 2018

2.5 is relatively recent, so I'd feel OK about slightly bending the "no changes in behaviour" rule for this case.

@strk

This comment has been minimized.

Copy link
Member

commented Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.