Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Impose minimum number of segments per arc during linearization #320
6 days ago the original ticket author had no way to know about this PR. Pinging things to get them moving on github is my duty :)
It passes tests, passes coverage, and if it's covering the issues mentioned by ticket author - I'd say we just merge it and close ticket. If there are some more issues, that would deserve a new ticket.
If you're planning to backport it, 2.5.1 is in a few weeks according to @robe2's email.
@strk @robe2 @pramsey Do you have any thoughts about backporting the changes included in this PR to 2.5.x? On the one hand, they include a behavior change -- I had to change several test results -- but on the other hand, they fix a reported bug, and it's hard to imagine a case where the older behavior (linearizing an arc with a single straight line) is desirable.