New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with skipped tests not being cleaned up properly #33

Closed
wants to merge 1 commit into
base: svn-trunk
from

Conversation

Projects
None yet
4 participants
@maurizi

maurizi commented Feb 11, 2015

This was what was causing the untracked file I noticed in #32.

@strk

This comment has been minimized.

Show comment
Hide comment
@strk

strk Feb 12, 2015

Member

but, why was the test skipped ? Reading the code it looks like the skip is due to a missing file. Why is there a "pre" without a corresponding file ? There might be another bug hiding here

Member

strk commented Feb 12, 2015

but, why was the test skipped ? Reading the code it looks like the skip is due to a missing file. Why is there a "pre" without a corresponding file ? There might be another bug hiding here

@dustymugs

This comment has been minimized.

Show comment
Hide comment
@dustymugs

dustymugs Feb 12, 2015

Contributor

Having the *-post.pl run regardless of the test succeeding makes sense. The test itself isn't being skipped (as far as the latest trunk indicates). The *-pre generates the appropriate opt file and the *-post destroys it.

Contributor

dustymugs commented Feb 12, 2015

Having the *-post.pl run regardless of the test succeeding makes sense. The test itself isn't being skipped (as far as the latest trunk indicates). The *-pre generates the appropriate opt file and the *-post destroys it.

@maurizi

This comment has been minimized.

Show comment
Hide comment
@maurizi

maurizi Feb 12, 2015

@strk I think you're right, there is some underlying bug if the BasicOutDb test is being skipped. Perhaps it is something specific to my environment that is causing the test to be skipped.

That said, it seems like a good practice to always run the *-post.pl if we run the corresponding *-pre.pl, regardless of whether the actual test is run or not.

maurizi commented Feb 12, 2015

@strk I think you're right, there is some underlying bug if the BasicOutDb test is being skipped. Perhaps it is something specific to my environment that is causing the test to be skipped.

That said, it seems like a good practice to always run the *-post.pl if we run the corresponding *-pre.pl, regardless of whether the actual test is run or not.

@strk

This comment has been minimized.

Show comment
Hide comment
@strk

strk Feb 12, 2015

Member

if we figure out what triggers the skip, it would probably make sense to skip the test completely, not running the *-pre.pl either.

Member

strk commented Feb 12, 2015

if we figure out what triggers the skip, it would probably make sense to skip the test completely, not running the *-pre.pl either.

@maurizi maurizi changed the title from Fix issue with skiped tests not being cleaned up properly to Fix issue with skipped tests not being cleaned up properly Dec 12, 2015

@pramsey

This comment has been minimized.

Show comment
Hide comment
Member

pramsey commented Feb 24, 2016

@pramsey pramsey closed this Feb 24, 2016

strk pushed a commit that referenced this pull request Feb 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment