Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgresql 12 build #368

Closed
wants to merge 4 commits into from

Conversation

@Algunenano
Copy link
Member

commented Jan 30, 2019

@Algunenano Algunenano force-pushed the Algunenano:trunk12_3001 branch from a44f0be to 0f008d8 Jan 30, 2019

@@ -147,7 +147,9 @@ static rtpg_nmapalgebra_arg rtpg_nmapalgebra_arg_init() {
arg->cextent = NULL;
arg->mask = NULL;

#if POSTGIS_PGSQL_VERSION >= 120

This comment has been minimized.

Copy link
@laurenz

laurenz Jan 30, 2019

Thanks for catching that omission.

@Algunenano

This comment has been minimized.

Copy link
Member Author

commented Jan 30, 2019

Travis is running a week old PG 12 so the build is failing. @Komzpa @dbaston Any chance of updating it to HEAD to test this PR?

@dbaston

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

@Algunenano I'll try to push an update. It's probably a good idea to get this run automatically on debbie or some other shared infrastructure; I don't really have interest to maintain this going forward.

@dbaston

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

Updated PG12 on Travis; re-ran build.

@Algunenano

This comment has been minimized.

Copy link
Member Author

commented Jan 31, 2019

Updated PG12 on Travis; re-ran build.

Thanks a lot. Should we ask Regina for help to move this into one of the bots?

@Algunenano

This comment has been minimized.

Copy link
Member Author

commented Jan 31, 2019

The tests for PG12 aren't passing but they work it you use FUNC_MAX_ARGS. I'll try to see which of the functions is using more parameters than declared.

@Algunenano

This comment has been minimized.

Copy link
Member Author

commented Jan 31, 2019

The tests for PG12 aren't passing but they work it you use FUNC_MAX_ARGS. I'll try to see which of the functions is using more parameters than declared.

After thinking about it, and looking at the code, I've decided to push it using FUNC_MAX_ARGS and leave the size optimization to whoever might be interested.

@Komzpa

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

After thinking about it, and looking at the code, I've decided to push it using FUNC_MAX_ARGS and leave the size optimization to whoever might be interested.

Please leave a ticket for "PostGIS Fund Me" milestone so knowledge of this deficiency is not lost.

@laurenz

This comment has been minimized.

Copy link

commented Jan 31, 2019

That's the safe route to take.

I have tried to figure out the maxima by reading the code; I must have made a mistake somewhere.

Using FUNC_MAX_ARGS is probably a waste, but it is no worse than the pre-existing code.

Then maybe initializations like here, here, here and here also need to be revisited. I hard-coded the limit of 3 there.

strk pushed a commit that referenced this pull request Jan 31, 2019

PostgreSQL 12 compatibility
Initial patch by Laurenz Albe
Closes #4313
Closes #368



git-svn-id: http://svn.osgeo.org/postgis/branches/2.4@17225 b70326c6-7e19-0410-871a-916f4a2858ee

@Algunenano Algunenano closed this Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.