Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve detection of packages (pkg-config) #372

Closed
wants to merge 14 commits into from

Conversation

Projects
None yet
2 participants
@Algunenano
Copy link
Member

commented Feb 8, 2019

  • Use pkg-config if available.
  • Only add ACCEPT_USE_OF_DEPRECATED_PROJ_API_H if using PROJ6.
  • Add PROJ_CPPFLAGS to the CPPFLAGS, which should allow us to remove ACCEPT_USE_OF_DEPRECATED_PROJ_API_H from the code itself.
@pramsey

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

I was just looking at what it would take to move to the new proj.h API for proj6+ (apparently I cannot ACCEPT_USE_OF_DEPRECATED_PROJ_API_H), if you're already there, any interest in doing that? Otherwise, merge at your earliest convenience and I'll carry on.

@Algunenano

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2019

apparently I cannot ACCEPT_USE_OF_DEPRECATED_PROJ_API_H

That is odd. Tests with current trunk in travis pass. 🤷‍♂

if you're already there, any interest in doing that?

You are not the first to ask me that question lately ;D In my plans, I intend to at least have a look to see how hard it'd be to adapt and what benefits it'd bring, but I don't have the bandwidth right now.

Otherwise, merge at your earliest convenience and I'll carry on.

Sadly it's not passing the PROJ6 build (it's optional but it was passing before) as the CPPFLAGS aren't propagated. I'm checking that now.

@Algunenano

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2019

So, I decided to do to the same with json-c; and the next one is libpcre, which is being used in in the address parser.

This all comes from the fact that I expect: ./autogen.sh && ./configure && make to just work in OSX and it wasn't. I'm tempted to remove the with-XX=dir and make pkg-config mandatory but I don't want to screw Windows too much.

@Algunenano Algunenano force-pushed the Algunenano:pkg_proj branch from 673a49c to 417190a Feb 11, 2019

@Algunenano Algunenano force-pushed the Algunenano:pkg_proj branch from 417190a to 512cf47 Feb 11, 2019

@Algunenano Algunenano changed the title Improve detection of PROJ Improve detection of packages (pkg-config) Feb 11, 2019

@strk strk closed this in 63a8e93 Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.