Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove errorIfGeometryCollection checking on file lwgeom_geos.c #386

Closed

Conversation

@estebanzimanyi
Copy link

commented Mar 25, 2019

Remove the restriction that functions ST_Equal, ST_Contains, ST_Relate, etc. cannot accept GeometryCollection arguments. This was a restriction of an older version of GEOS that according to my understanding is no longer true.

@Algunenano

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

Can you add tests (either in SQL/regress or in C/cunit) to check this, please? Then we can rely on travis to make sure it's available in GEOS 3.6+

@Algunenano

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

Hi,

You are modifying at least 11 functions:

  C function       -- SQL function
- overlaps         -- ST_Overlaps(geom1 geometry, geom2 geometry)
- contains         -- ST_Contains(geom1 geometry, geom2 geometry)
- containsproperly -- ST_ContainsProperly(geom1 geometry, geom2 geometry)
- covers           -- ST_Covers(geom1 geometry, geom2 geometry)
- coveredby        -- ST_CoveredBy(geom1 geometry, geom2 geometry)
- crosses          -- ST_Crosses(geom1 geometry, geom2 geometry)
- touches          -- ST_Touches(geom1 geometry, geom2 geometry)
- disjoint         -- ST_Disjoint(geom1 geometry, geom2 geometry)
- relate_pattern   -- ST_Relate(geom1 geometry, geom2 geometry,text)
- relate_full      -- ST_Relate(geom1 geometry, geom2 geometry) // ST_Relate(geom1 geometry, geom2 geometry, int4)
- ST_Equals        -- ST_Equals(geom1 geometry, geom2 geometry)

Can you please add simple test for all of them (at least one per C function passing geometry collections in all parameters)?

Also, in terms of documentation prefer adding a line like

<para>Enhanced: 3.0.0 implemented a minimum number of segments per linearized arc to prevent topological collapse.</para>

 <para>Enhanced: 3.0.0 enabled support for GeometryCollections</para> 

@Komzpa Komzpa self-requested a review Apr 7, 2019

@Komzpa
Komzpa approved these changes Apr 7, 2019

@strk strk closed this in cb0e3bc Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.