Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ubsan implicit conversion sanitizer to clang #398

Closed
wants to merge 4 commits into from

Conversation

@Algunenano
Copy link
Member

commented Apr 24, 2019

WIP.

  • postgis/postgis-build-env#3 should to be merged too 馃檹
  • I've already cleaned the errors in liblwgeom and core regress, but raster and topology is still pending, thus that build doesn't pass the tests yet.

@Algunenano Algunenano force-pushed the Algunenano:travis_implicit branch from 4f1ca18 to bf211f7 Apr 25, 2019

@Algunenano

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

Raster is now passing, I'm addressing topology/ next.

@@ -1032,7 +1032,7 @@ rt_band_get_quantiles_stream(
uint32_t j = 0;
uint32_t k = 0;
uint32_t x = 0;
uint32_t y = 0;
int64_t y = 0;

This comment has been minimized.

Copy link
@Komzpa

Komzpa Apr 26, 2019

Member

why is x different from y?

This comment has been minimized.

Copy link
@Algunenano

Algunenano Apr 26, 2019

Author Member

x goes from 0 to band->width but y is initially setup as -1 and then it can either be replaced by an uint32_t value or added to a random bounded uint32_t.

To be honest, it is a 500 LOC function and reviewing how and this could be changed to use unsigned would take a lot of time. I'm good with doubling the precision and keeping the sanitizer happy.

@Komzpa

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

How about we merge this at least in part? that would be better already :)

@Algunenano

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2019

It's on my list. I indent to finish this (having all warnings/errors addressed) as soon as I can get back to postgis/trunk (soon 鈩笍)

@Algunenano Algunenano force-pushed the Algunenano:travis_implicit branch from bf211f7 to fd51ffe Jun 5, 2019

@strk strk closed this in 3bc9ee7 Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.