Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NODATA=NaN in Raster #407

Closed
wants to merge 4 commits into from

Conversation

@Komzpa
Copy link
Member

commented Jun 2, 2019

https://trac.osgeo.org/postgis/ticket/4412

Helps import Facebook population dataset.

Komzpa added 4 commits Jun 2, 2019
@robe2

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

See my note - https://trac.osgeo.org/postgis/ticket/4412

in short - I'm okay with this in 3.0, but introducing it in 2.5.3 feels a little dirty as it risks disstabilizing a stable release.

@strk strk closed this in 2318d2e Jun 3, 2019

@Komzpa Komzpa deleted the Komzpa:ticket-4412 branch Jun 3, 2019

@dbaston

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Seems OK in concept, but I didn't review the mixed formatting and logic changes. Should be noted as a breaking change in NEWS, I think. Is ST_PixelAsPolygons really the only affected function?

@Komzpa

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2019

@dbaston formatting is specially a separate commit, 7c23667 shows change without formatting (mostly 0 -> 0.0, as isnan(0) is not possible).

With ST_PixelAsPolygons we have at least one way of escaping from such raster into vector land.

It is not a breaking change as there's no working behavior we break, people who had a raster with NODATA NaN can't work with it at all using PostGIS - it comes out all-NODATA which is an obvious breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.