Speed up geometry output functions as text #523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks OK to me. No issues in regression suite? Pretty amazing. |
There are some minor changes (86772b0) but I've tried to match the output as closely as possible to reduce friction. Benchmarks: I'm going to test a couple of ideas to see if I improve things around the code introduced and merge soon ™️ |
|
Ryu introduced in 04f93f1, I'll add other PR's / commits with other improvements (stringbuffers, geojson, and so on). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Ryu to print doubles as proposed in https://trac.osgeo.org/postgis/ticket/4543
The changes include (I plan to push them in different commits once accepted):
Pending: Updated benchmark comparison of the affected functions (ST_AsText, ST_AsGeoJSON, etc).