Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up geometry output functions as text #523

wants to merge 17 commits into from


Copy link

This PR introduces Ryu to print doubles as proposed in

The changes include (I plan to push them in different commits once accepted):

  • Introduce ryu code in the tree and the build system.
  • Some minor changes to test output.
  • Disable clang-format in deps/.
  • Some speed improvements in stringbuffer_append to avoid repetead calls to strlen.
  • Wording imprrovements around double printing macros to clarify what they are doing.

Pending: Updated benchmark comparison of the affected functions (ST_AsText, ST_AsGeoJSON, etc).

Copy link

pramsey commented Dec 31, 2019

Looks OK to me. No issues in regression suite? Pretty amazing.

Copy link
Member Author

No issues in regression suite?

There are some minor changes (86772b0) but I've tried to match the output as closely as possible to reduce friction.


I'm going to test a couple of ideas to see if I improve things around the code introduced and merge soon ™️

@strk strk closed this in 04f93f1 Jan 10, 2020
Copy link
Member Author

Ryu introduced in 04f93f1, I'll add other PR's / commits with other improvements (stringbuffers, geojson, and so on).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants