ST_CurveN and ST_NumCurves plus consistency #762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
reviewed
Feb 21, 2024
| ST_GeometryType(ST_CurveN(geom,1)) as curven_1, | ||
| ST_GeometryType(ST_CurveN(geom,2)) as curven_2, | ||
| ST_GeometryType(ST_CurveN(geom,3)) as curven_3, | ||
| ST_GeometryType(ST_CurveN(geom,3)) as curven_4, |
There was a problem hiding this comment.
this repeats the curven_3 query. Is that indented, or was it rather ST_CurveN(geom,4) ?
doc/reference_accessor.xml
Outdated
| <programlisting> | ||
| -- Returns 3 | ||
| SELECT ST_NumCurves('COMPOUNDCURVE( | ||
| LINESTRING(2 2, 2.5 2.5), |
There was a problem hiding this comment.
My understanding of https://github.com/postgis/postgis/blob/8ed84517a9b86c86724504d1b6a0f0c1ccd86cf6/doc/bnf-wkt.txt is that the explicit LINESTRING() keyword within a COMPOUNDCURVE is not allowed, and a PostGIS, OGR, etc. extension. It should probably not be advertized here (and below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessors for the components of CompoundCurve, and changes to geometry accessors relative to CompoundCurve to respect that it is a unitary object, just like LineString and CircularString.