Please sign in to comment.
Fix walsender failure at promotion.
If a standby server has a cascading standby server connected to it, it's possible that WAL has already been sent up to the next WAL page boundary, splitting a WAL record in the middle, when the first standby server is promoted. Don't throw an assertion failure or error in walsender if that happens. Also, fix a variant of the same bug in pg_receivexlog: if it had already received WAL on previous timeline up to a segment boundary, when the upstream standby server is promoted so that the timeline switch record falls on the previous segment, pg_receivexlog would miss the segment containing the timeline switch. To fix that, have walsender send the position of the timeline switch at end-of-streaming, in addition to the next timeline's ID. It was previously assumed that the switch happened exactly where the streaming stopped. Note: this is an incompatible change in the streaming protocol. You might get an error if you try to stream over timeline switches, if the client is running 9.3beta1 and the server is more recent. It should be fine after a reconnect, however. Reported by Fujii Masao.
- Loading branch information...
Showing with 142 additions and 43 deletions.
- +9 −4 doc/src/sgml/protocol.sgml
- +3 −2 src/backend/access/transam/xlog.c
- +5 −2 src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
- +4 −3 src/backend/replication/walreceiverfuncs.c
- +41 −19 src/backend/replication/walsender.c
- +6 −4 src/bin/pg_basebackup/pg_receivexlog.c
- +74 −9 src/bin/pg_basebackup/receivelog.c