Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Aug 25, 2014
  1. @anarazel

    Fix typos in some error messages thrown by extension scripts when fed…

    anarazel authored
    … to psql.
    Some of the many error messages introduced in 458857c missed 'FROM
    unpackaged'. Also e016b72 and 45ffeb7 forgot to quote extension
    version numbers.
    Backpatch to 9.1, just like 458857c which introduced the messages. Do
    so because the error messages thrown when the wrong command is copy &
    pasted aren't easy to understand.
Commits on Jul 14, 2014
  1. @nmisch

    Add file version information to most installed Windows binaries.

    nmisch authored
    Prominent binaries already had this metadata.  A handful of minor
    binaries, such as pg_regress.exe, still lack it; efforts to eliminate
    such exceptions are welcome.
    Michael Paquier, reviewed by MauMau.
Commits on Jul 10, 2014
  1. @bmomjian
Commits on Apr 18, 2014
  1. @petere

    Create function prototype as part of PG_FUNCTION_INFO_V1 macro

    petere authored
    Because of gcc -Wmissing-prototypes, all functions in dynamically
    loadable modules must have a separate prototype declaration.  This is
    meant to detect global functions that are not declared in header files,
    but in cases where the function is called via dfmgr, this is redundant.
    Besides filling up space with boilerplate, this is a frequent source of
    compiler warnings in extension modules.
    We can fix that by creating the function prototype as part of the
    PG_FUNCTION_INFO_V1 macro, which such modules have to use anyway.  That
    makes the code of modules cleaner, because there is one less place where
    the entry points have to be listed, and creates an additional check that
    functions have the right prototype.
    Remove now redundant prototypes from contrib and other modules.
Commits on Nov 24, 2013
  1. Defend against bad trigger definitions in contrib/lo's lo_manage() tr…

    Tom Lane authored
    This function formerly crashed if called as a statement-level trigger,
    or if a column-name argument wasn't given.
    In passing, add the trigger name to all error messages from the function.
    (None of them are expected cases, so this shouldn't pose any compatibility
    Marc Cousin, reviewed by Sawada Masahiko
Commits on Oct 12, 2011
  1. Throw a useful error message if an extension script file is fed to psql.

    Tom Lane authored
    We have seen one too many reports of people trying to use 9.1 extension
    files in the old-fashioned way of sourcing them in psql.  Not only does
    that usually not work (due to failure to substitute for MODULE_PATHNAME
    and/or @extschema@), but if it did work they'd get a collection of loose
    objects not an extension.  To prevent this, insert an \echo ... \quit
    line that prints a suitable error message into each extension script file,
    and teach commands/extension.c to ignore lines starting with \echo.
    That should not only prevent any adverse consequences of loading a script
    file the wrong way, but make it crystal clear to users that they need to
    do it differently now.
    Tom Lane, following an idea of Andrew Dunstan's.  Back-patch into 9.1
    ... there is not going to be much value in this if we wait till 9.2.
Commits on Sep 1, 2011
  1. @bmomjian
Commits on Jul 4, 2011
  1. @alvherre

    Move Trigger and TriggerDesc structs out of rel.h into a new reltrigg…

    alvherre authored
    This lets us stop including rel.h into execnodes.h, which is a widely
    used header.
Commits on Feb 14, 2011
  1. Avoid use of CREATE OR REPLACE FUNCTION in extension installation files.

    Tom Lane authored
    It was never terribly consistent to use OR REPLACE (because of the lack of
    comparable functionality for data types, operators, etc), and
    experimentation shows that it's now positively pernicious in the extension
    world.  We really want a failure to occur if there are any conflicts, else
    it's unclear what the extension-ownership state of the conflicted object
    ought to be.  Most of the time, CREATE EXTENSION will fail anyway because
    of conflicts on other object types, but an extension defining only
    functions can succeed, with bad results.
  2. Convert contrib modules to use the extension facility.

    Tom Lane authored
    This isn't fully tested as yet, in particular I'm not sure that the
    "foo--unpackaged--1.0.sql" scripts are OK.  But it's time to get some
    buildfarm cycles on it.
    sepgsql is not converted to an extension, mainly because it seems to
    require a very nonstandard installation process.
    Dimitri Fontaine and Tom Lane
Commits on Sep 22, 2010
  1. @mhagander
Commits on Sep 20, 2010
  1. @mhagander
Commits on Dec 14, 2009
  1. @itagaki-takahiro

    Additional fixes for large object access control.

    itagaki-takahiro authored
    Use pg_largeobject_metadata.oid instead of pg_largeobject.loid
    to enumerate existing large objects in pg_dump, pg_restore, and
    contrib modules.
Commits on Nov 13, 2007
  1. @bmomjian
Commits on Nov 11, 2007
  1. @bmomjian

    Make /contrib install/uninstall script consistent:

    bmomjian authored
    	remove transactions
    	use create or replace function
    	make formatting consistent
    	set search patch on first line
    Add documentation on modifying *.sql to set the search patch, and
    mention that major upgrades should still run the installation scripts.
    Some of these issues were spotted by Tom today.
Commits on Nov 10, 2007
  1. @bmomjian
  2. @bmomjian

    Move most /contrib README files into SGML. Some still need conversion

    bmomjian authored
    or will never be converted.
Commits on Jun 26, 2007
  1. Fix PGXS conventions so that extensions can be built against Postgres

    Tom Lane authored
    installations whose pg_config program does not appear first in the PATH.
    Per gripe from Eddie Stanley and subsequent discussions with Fabien Coelho
    and others.
Commits on Sep 11, 2006
  1. Rename the uninstall scripts for contrib/lo and contrib/tsearch2 to

    Tom Lane authored
    match the convention that foo's uninstall script is uninstall_foo.sql.
    Also, stop installing lo_test.sql, which really ought to be made into
    a regression test anyway (though it's unclear how to avoid a dependency
    on the current OID counter...)
Commits on Jul 11, 2006
  1. @bmomjian
Commits on May 30, 2006
  1. Magic blocks don't do us any good unless we use 'em ... so install one

    Tom Lane authored
    in every shared library.
Commits on Sep 27, 2005
  1. PGXS should be set with := not =, as specified in the documentation,

    Tom Lane authored
    to avoid useless multiple executions of pg_config.
Commits on Jun 23, 2005
  1. Cleanup the contrib/lo module: there is no need anymore to implement

    Tom Lane authored
    a physically separate type.  Defining 'lo' as a domain over OID works
    just fine and is more efficient.  Improve documentation and fix up the
    test script.  (Would like to turn test script into a proper regression
    test, but right now its output is not constant because of numeric OIDs;
    plus it makes Unix-specific assumptions about files it can import.)
Commits on Jan 29, 2005
  1. Make sure contrib C functions are marked strict where needed.

    Tom Lane authored
    Kris Jurka
Commits on Aug 20, 2004
  1. @bmomjian

    > Please find enclose a submission to fix these problems.

    bmomjian authored
    > The patch adds missing the "libpgport.a" file to the installation under
    > "install-all-headers". It is needed by some contribs. I install the
    > library in "pkglibdir", but I was wondering whether it should be "libdir"?
    > I was wondering also whether it would make sense to have a ""?
    > It fixes various macros which are used by contrib makefiles, especially
    > libpq_*dir and LDFLAGS when used under PGXS. It seems to me that they are
    > needed to
    > It adds the ability to test and use PGXS with contribs, with "make
    > USE_PGXS=1". Without the macro, this is exactly as before, there should be
    > no difference, esp. wrt the vpath feature that seemed broken by previous
    > submission. So it should not harm anybody, and it is useful at least to me.
    > It fixes some inconsistencies in various contrib makefiles
    > (useless override, ":=" instead of "=").
    Fabien COELHO
Commits on Nov 29, 2003
  1. make sure the $Id tags are converted to $PostgreSQL as well ...

    PostgreSQL Daemon authored
  2. $Header: -> $PostgreSQL Changes ...

    PostgreSQL Daemon authored
Commits on Jul 24, 2003
Commits on May 14, 2003
  1. Backend support for autocommit removed, per recent discussions. The

    Tom Lane authored
    only remnant of this failed experiment is that the server will take
    SET AUTOCOMMIT TO ON.  Still TODO: provide some client-side autocommit
    logic in libpq.
Commits on Dec 31, 2002
  1. Add casts between lo and oid.

    Hiroshi Inoue authored
Commits on Oct 18, 2002
  1. @bmomjian

    Update /contrib for "autocommit TO 'on'".

    bmomjian authored
    Create objects in public schema.
    Make spacing/capitalization consistent.
    Remove transaction block use for object creation.
    Remove unneeded function GRANTs.
Commits on Aug 22, 2002
  1. Add a bunch of pseudo-types to replace the behavior formerly associated

    Tom Lane authored
    with OPAQUE, as per recent pghackers discussion.  I still want to do some
    more work on the 'cstring' pseudo-type, but I'm going to commit the bulk
    of the changes now before the tree starts shifting under me ...
Commits on Aug 15, 2002
  1. @bmomjian

    The attached patch changes most of the usages of sprintf() to

    bmomjian authored
    snprintf() in contrib/. I didn't touch the places where pointer
    arithmatic was being used, or other areas where the fix wasn't
    trivial. I would think that few, if any, of the usages of sprintf()
    were actually exploitable, but it's probably better to be paranoid...
    Neil Conway
Commits on Dec 7, 2001
  1. Fix a lo_manage()'s bug.

    Hiroshi Inoue authored
Commits on Oct 28, 2001
  1. @bmomjian

    Another pgindent run. Fixes enum indenting, and improves #endif

    bmomjian authored
    spacing.  Also adds space for one-line comments.
Something went wrong with that request. Please try again.