Remove LightGBM dump after deserialization (#474)

levkk · web-flow · commit b0f23a7d583e · 2022-11-03T09:39:13.000-07:00
diff --git a/pgml-extension/src/bindings/lightgbm.rs b/pgml-extension/src/bindings/lightgbm.rs
@@ -123,6 +123,7 @@ impl Bindings for Estimator {
             std::fs::write(&path, &bytes[16..]).unwrap();
             estimator = lightgbm::Booster::from_file(&path);
         }
+        std::fs::remove_file(&path).unwrap();
         Box::new(Estimator {
             estimator: estimator.unwrap(),
         })

Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,7 @@ impl Bindings for Estimator {`
`123`	`123`	`std::fs::write(&path, &bytes[16..]).unwrap();`
`124`	`124`	`estimator = lightgbm::Booster::from_file(&path);`
`125`	`125`	`}`
	`126`	`+ std::fs::remove_file(&path).unwrap();`
`126`	`127`	`Box::new(Estimator {`
`127`	`128`	`estimator: estimator.unwrap(),`
`128`	`129`	`})`