set_archiving_conf and tablespace cleanup removed, based on Dmitry Ivanov feedback

Author: gsmolk

testgres/testgres.py

@@ -262,26 +262,6 @@ def init_from_backup(self, root_node, backup_name, has_streaming=False,
         if has_streaming:
             self.enable_streaming(root_node)
 
-    def set_archiving_conf(self, archive_dir):
-        self.append_conf(
-                "postgresql.auto.conf",
-                "wal_level = archive"
-                )
-        self.append_conf(
-                "postgresql.auto.conf",
-                "archive_mode = on"
-                )
-        if os.name == 'posix':
-            self.append_conf(
-                    "postgresql.auto.conf",
-                    "archive_command = 'test ! -f {0}/%f && cp %p {0}/%f'".format(archive_dir)
-                    )
-        elif os.name == 'nt':
-            self.append_conf(
-                    "postgresql.auto.conf",
-                    "archive_command = 'copy %p {0}\\%f'".format(archive_dir)
-                    )
-
     def set_replication_conf(self):
         hba_conf = os.path.join(self.data_dir, "pg_hba.conf")
         with open(hba_conf, "a") as conf:
@@ -382,6 +362,7 @@ def get_pid(self):
             return None
 
     def get_control_data(self):
+        """ Return pg_control content """
         out_data = {}
         pg_controldata = self.get_bin_path("pg_controldata")
         try:
@@ -440,9 +421,6 @@ def cleanup(self):
                 pass
 
         # remove data directory
-        tblspace_list = os.listdir(os.path.join(self.data_dir, 'pg_tblspc'))
-        for i in tblspace_list:
-            shutil.rmtree(os.readlink(os.path.join(self.data_dir, 'pg_tblspc', i)))
         shutil.rmtree(self.data_dir)
 
         return self
@@ -457,7 +435,7 @@ def psql(self, dbname, query=None, filename=None, username=None):
         """
         psql = self.get_bin_path("psql")
         psql_params = [
-           psql, "-XAtq", "-h127.0.0.1", "-p {}".format(self.port), dbname
+           psql, "-XAtq", "-h{}".format(self.host), "-p {}".format(self.port), dbname
         ]
 
         if query: