Skip to content

Conversation

@mrmlnc
Copy link
Member

@mrmlnc mrmlnc commented Dec 6, 2016

Proposed Changes

Source: #33

Types of Changes

  • Feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING guide
  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

Further Comments

Reviewers: @posthtml/collaborators

@mrmlnc mrmlnc added the feature label Dec 6, 2016
@mrmlnc mrmlnc added this to the v1.1.0 milestone Dec 6, 2016
@coveralls
Copy link

coveralls commented Dec 6, 2016

Coverage Status

Coverage decreased (-0.2%) to 97.175% when pulling 411091d on mrmlnc:switch into 0eeacc9 on posthtml:master.

@michael-ciniawsky
Copy link
Member

👍 Cool 😎 , I take a deeper look at it later/until tomorrow, I'm on mobile atm.

Copy link
Contributor

@jescalan jescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, nice and clean. Good work!

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Could you rebase to Angular Commit Convention for CHANGELOG generation please ? 😛

 docs(index): mrmlnc is Denis Malinochkin 
 fix(index): copy/paste for loops
 feat(index): add switch statement
 test(*): add tests for switch statement
 docs(README): add docs for switch statement
 fix(index): comments 		

@coveralls
Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage decreased (-0.2%) to 97.175% when pulling 553b0fa on mrmlnc:switch into 0eeacc9 on posthtml:master.

@mrmlnc
Copy link
Member Author

mrmlnc commented Dec 13, 2016

@michael-ciniawsky, done(); 😅

@michael-ciniawsky
Copy link
Member

👍

@michael-ciniawsky michael-ciniawsky merged commit 6643007 into posthtml:master Dec 13, 2016
@mrmlnc
Copy link
Member Author

mrmlnc commented Dec 13, 2016

@michael-ciniawsky, how to I can get green light for Coveralls?

@michael-ciniawsky
Copy link
Member

@mrmlnc hmmm... 😛 L251,322,329 (switch errors) are shown as uncovered, but they are definitely tested. I don't know tbh, as long as it works we simply don't mind for now 👀 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants