-
-
Notifications
You must be signed in to change notification settings - Fork 18
Switch statement #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch statement #36
Conversation
|
👍 Cool 😎 , I take a deeper look at it later/until tomorrow, I'm on mobile atm. |
jescalan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, nice and clean. Good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Could you rebase to Angular Commit Convention for CHANGELOG generation please ? 😛
docs(index): mrmlnc is Denis Malinochkin
fix(index): copy/paste for loops
feat(index): add switch statement
test(*): add tests for switch statement
docs(README): add docs for switch statement
fix(index): comments
|
@michael-ciniawsky, |
|
👍 |
|
@michael-ciniawsky, how to I can get green light for Coveralls? |
|
@mrmlnc hmmm... 😛 L251,322,329 (switch errors) are shown as uncovered, but they are definitely tested. I don't know tbh, as long as it works we simply don't mind for now 👀 ? |
Proposed Changes
Source: #33
Types of Changes
Checklist
Further Comments
Reviewers: @posthtml/collaborators