From 8174af77370434cc328e4c7bf24049d6e5ba0a16 Mon Sep 17 00:00:00 2001 From: lukareihl Date: Wed, 11 Oct 2023 16:43:37 +0200 Subject: [PATCH 1/2] Introduce PSR-4 autoloading --- composer.json | 22 ++++---- phpunit.xml | 2 +- CloudEngine.php => src/CloudEngine.php | 42 +++++++-------- .../CloudRequestEngine.php | 46 ++++++++--------- .../CloudRequestException.php | 44 ++++++++-------- Constants.php => src/Constants.php | 44 ++++++++-------- HttpClient.php => src/HttpClient.php | 42 +++++++-------- tests/CloudRequestEngineTests.php | 49 ++++++++---------- tests/CloudRequestEngineTestsBase.php | 47 ++++++++--------- tests/CloudRequestTests.php | 51 +++++++++---------- tests/CloudResponse.php | 48 ++++++++--------- tests/MissingPropertyHandling.php | 50 +++++++++--------- 12 files changed, 231 insertions(+), 256 deletions(-) rename CloudEngine.php => src/CloudEngine.php (99%) rename CloudRequestEngine.php => src/CloudRequestEngine.php (98%) rename CloudRequestException.php => src/CloudRequestException.php (98%) rename Constants.php => src/Constants.php (99%) rename HttpClient.php => src/HttpClient.php (99%) diff --git a/composer.json b/composer.json index 5c9914b..28ecff6 100644 --- a/composer.json +++ b/composer.json @@ -22,17 +22,21 @@ ], "license": "EUPL-1.2", "type": "library", - "autoload": { - "classmap": [ - "CloudRequestEngine.php", - "CloudRequestException.php", - "CloudEngine.php", - "Constants.php", - "HttpClient.php" - ] - }, "require": { "51degrees/fiftyone.pipeline.engines": "4.*", "51degrees/fiftyone.pipeline.core": "4.*" + }, + "require-dev": { + "phpunit/phpunit": "*" + }, + "autoload": { + "psr-4": { + "fiftyone\\pipeline\\cloudrequestengine\\": "src/" + } + }, + "autoload-dev": { + "psr-4": { + "fiftyone\\pipeline\\cloudrequestengine\\tests\\": "tests/" + } } } diff --git a/phpunit.xml b/phpunit.xml index 7aabf15..a4a27d4 100644 --- a/phpunit.xml +++ b/phpunit.xml @@ -1,4 +1,4 @@ - + diff --git a/CloudEngine.php b/src/CloudEngine.php similarity index 99% rename from CloudEngine.php rename to src/CloudEngine.php index c9d341b..c0457b1 100644 --- a/CloudEngine.php +++ b/src/CloudEngine.php @@ -1,24 +1,24 @@ -LowerCaseArrayKeys($properties); + $properties = $this->lowerCaseArrayKeys($properties); $flowElementProperties = array(); diff --git a/CloudRequestException.php b/src/CloudRequestException.php similarity index 98% rename from CloudRequestException.php rename to src/CloudRequestException.php index 7e5ee30..c0e0821 100644 --- a/CloudRequestException.php +++ b/src/CloudRequestException.php @@ -1,24 +1,24 @@ -responseHeaders = $responseHeaders; } -} \ No newline at end of file +} diff --git a/Constants.php b/src/Constants.php similarity index 99% rename from Constants.php rename to src/Constants.php index 68ba427..6288518 100644 --- a/Constants.php +++ b/src/Constants.php @@ -1,24 +1,24 @@ - Date: Wed, 11 Oct 2023 16:43:37 +0200 Subject: [PATCH 2/2] Introduce PSR-4 autoloading --- composer-dev.json | 10 ++-- composer.json | 22 ++++---- phpunit.xml | 2 +- CloudEngine.php => src/CloudEngine.php | 42 +++++++-------- .../CloudRequestEngine.php | 46 ++++++++--------- .../CloudRequestException.php | 44 ++++++++-------- Constants.php => src/Constants.php | 44 ++++++++-------- HttpClient.php => src/HttpClient.php | 42 +++++++-------- tests/CloudRequestEngineTests.php | 49 ++++++++---------- tests/CloudRequestEngineTestsBase.php | 47 ++++++++--------- tests/CloudRequestTests.php | 51 +++++++++---------- tests/CloudResponse.php | 48 ++++++++--------- tests/MissingPropertyHandling.php | 50 +++++++++--------- 13 files changed, 234 insertions(+), 263 deletions(-) rename CloudEngine.php => src/CloudEngine.php (99%) rename CloudRequestEngine.php => src/CloudRequestEngine.php (98%) rename CloudRequestException.php => src/CloudRequestException.php (98%) rename Constants.php => src/Constants.php (99%) rename HttpClient.php => src/HttpClient.php (99%) diff --git a/composer-dev.json b/composer-dev.json index 98f22c6..66e309e 100644 --- a/composer-dev.json +++ b/composer-dev.json @@ -23,13 +23,9 @@ "license": "EUPL-1.2", "type": "library", "autoload": { - "classmap": [ - "CloudRequestEngine.php", - "CloudRequestException.php", - "CloudEngine.php", - "Constants.php", - "HttpClient.php" - ] + "psr-4": { + "fiftyone\\pipeline\\cloudrequestengine\\": "src/" + } }, "repositories": [ { diff --git a/composer.json b/composer.json index 5c9914b..28ecff6 100644 --- a/composer.json +++ b/composer.json @@ -22,17 +22,21 @@ ], "license": "EUPL-1.2", "type": "library", - "autoload": { - "classmap": [ - "CloudRequestEngine.php", - "CloudRequestException.php", - "CloudEngine.php", - "Constants.php", - "HttpClient.php" - ] - }, "require": { "51degrees/fiftyone.pipeline.engines": "4.*", "51degrees/fiftyone.pipeline.core": "4.*" + }, + "require-dev": { + "phpunit/phpunit": "*" + }, + "autoload": { + "psr-4": { + "fiftyone\\pipeline\\cloudrequestengine\\": "src/" + } + }, + "autoload-dev": { + "psr-4": { + "fiftyone\\pipeline\\cloudrequestengine\\tests\\": "tests/" + } } } diff --git a/phpunit.xml b/phpunit.xml index 7aabf15..a4a27d4 100644 --- a/phpunit.xml +++ b/phpunit.xml @@ -1,4 +1,4 @@ - + diff --git a/CloudEngine.php b/src/CloudEngine.php similarity index 99% rename from CloudEngine.php rename to src/CloudEngine.php index c9d341b..c0457b1 100644 --- a/CloudEngine.php +++ b/src/CloudEngine.php @@ -1,24 +1,24 @@ -LowerCaseArrayKeys($properties); + $properties = $this->lowerCaseArrayKeys($properties); $flowElementProperties = array(); diff --git a/CloudRequestException.php b/src/CloudRequestException.php similarity index 98% rename from CloudRequestException.php rename to src/CloudRequestException.php index 7e5ee30..c0e0821 100644 --- a/CloudRequestException.php +++ b/src/CloudRequestException.php @@ -1,24 +1,24 @@ -responseHeaders = $responseHeaders; } -} \ No newline at end of file +} diff --git a/Constants.php b/src/Constants.php similarity index 99% rename from Constants.php rename to src/Constants.php index 68ba427..6288518 100644 --- a/Constants.php +++ b/src/Constants.php @@ -1,24 +1,24 @@ -