feat: Add a custom extractor for www.engadget.com. #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing content for cron.weekly issues, such as the one at https://ma.ttias.be/cronweekly/issue-130/, Mercury Parser would remove headings and ordered lists that were part of the content. This resolves that as follows: * Remove "id" attributes from "h1" and "h2" elements. Those attributes would result in the elements having a low weight. * Since Mercury Parser demotes "h1" elements to "h2", demote "h2" elements to "h3". * Add class="entry-content-asset" to "ul" elements to avoid them being removed.
jbrayton
added a commit
to jbrayton/mercury-parser
that referenced
this pull request
Apr 27, 2020
ezequiel454
added a commit
to RecastLLC/mercury-parser
that referenced
this pull request
Aug 25, 2021
added custom engadget
johnholdun
approved these changes
Aug 10, 2022
Contributor
johnholdun
left a comment
johnholdun
left a comment
There was a problem hiding this comment.
Looks good! I don't have a suggestion for getting timestamps, but it's a problem I've seen pop up elsewhere so I'm thinking about a way to solve it. If we come up with something, we'll make sure this extractor gets updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a custom extractor for www.engadget.com.
Engadget articles have dates, but I was unable to find one in a format I could parse. There are strings like "2h ago" and tags with blank values such as this:
So the extractor always returns a null date.
Engadget articles also have lead images, but I was unable to return the value. For example, the fixture has:
If I put a simpler URL in that value, I could select the image. I think the
ℑsequence in the URL is messing things up. I did incorporate lead images into the HTML content.If someone reviewing this thinks there is a good way to address these issues I am eager to do that.