Skip to content

Remove check if address is on local subnet for unicast scanning #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
postlund opened this issue Jul 20, 2020 · 0 comments · Fixed by #776
Closed

Remove check if address is on local subnet for unicast scanning #775

postlund opened this issue Jul 20, 2020 · 0 comments · Fixed by #776
Labels
breaking change API breaking change will happen feature

Comments

@postlund
Copy link
Owner

postlund commented Jul 20, 2020 •
edited
Loading

Short feature/function description
The feature will break when in NAT mode (e.g. host network mode in docker). So it's problematic and best to remove for now.

What needs to be done?
Revert #581.

Is this a breaking change?
Yes, the NonLocalSubnetError exception will no longer be used and marked as deprecated

Anything else worth knowing?
See #765.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change API breaking change will happen feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scan: Remove check if host is on any local subnet postlund/pyatv
1 participant
@postlund