Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data from input not populating variables in requests when clicking retry in collection runner after first run #4824

Closed
jameseg opened this issue Jul 13, 2018 · 7 comments

Comments

Projects
None yet
5 participants
@jameseg
Copy link

commented Jul 13, 2018

Please read through the guidelines before creating a new issue.

Describe the bug
A clear and concise description of what the bug is.
Clicking retry after a first run in collection runner with a data sheet(JSON in my case) is rerunning the requests, but no data is showing in the previously run requests.

Example:
1st call with data sheet where 2 is set as 'number' for one of the iters:
url-blahblah-endpoint?number=2
is working as expected.

2nd call with same data sheet after clicking 'Retry' button:
url-blahblah-endpoint?number= is getting sent as the request.
It's like the data is gone or not cached.

To Reproduce
Steps to reproduce the behavior:

  1. Create a collection of GETS that have variables in the request, eg. {{number}} for above
  2. Click 'Runner'
  3. Select your collection
  4. Select a data file, preferably JSON format
  5. Select 'application/json' for Data File Type
  6. Check Persist Variables checkbox
  7. Click Run datasheets
  8. Note the url being sent including your data you have set (i.e., what is the {{number} being sent?}
  9. Click 'Retry'
  10. See the variable value being sent in the url is gone ("")

Expected behavior
A clear and concise description of what you expected to happen.
I would expect the 'Retry' would do just that, retry the same requests with data set in the first attempt.

Screenshots
If applicable, add screenshots to help explain your problem.
Before first run:
image

Results after first run, you can see data populated the urls (first call is empty on purpose):
image

Results after 'Retry', no data in variables:
image

App information (please complete the following information):

  • App Type Native App
  • Postman Version v6.1.4
  • OS: Windows 10 Enterprise

Additional context
Add any other context about the problem here.
The workaround seems to be to click 'New' and run it again from scratch.

@numaanashraf numaanashraf added the bug label Jul 24, 2018

@sivcan sivcan added feature and removed bug labels Aug 1, 2018

@sivcan

This comment has been minimized.

Copy link
Member

commented Aug 1, 2018

@jameseg We do not store data file paths anywhere in the Postman Environment.
This will be solved in a similar way when this issue will be resolved: #4320

We'll be tracking further updates on that thread.

@sivcan sivcan closed this Aug 1, 2018

@sivcan sivcan added bug and removed feature labels Aug 1, 2018

@jameseg

This comment has been minimized.

Copy link
Author

commented Aug 1, 2018

? The retry button doesn't work correctly. If you're not saving the data in the environment, then it's broken and therefore a bug How can you expect the retry button to work if you have no access to the data file after it's run??

@sivcan

This comment has been minimized.

Copy link
Member

commented Aug 1, 2018

@jameseg It's a bug but the only reason we are not storing any data file paths is because of security reasons associated with it.

You chose the data file and the runner runs the run.
However, once the run is finished we discard all the file paths and just store the run's result.
On retrying the run, it would not take up any data file that was previously provided before running the run.

I understand it's a bug but the thread that I mentioned above aims to solve the use case of storing file paths throughout the app in a secure way.

We'll be tracking all the issues related to file paths in the same thread. :)

@jameseg

This comment has been minimized.

Copy link
Author

commented Aug 1, 2018

Ok fair enough. I'm wondering why save the path though. Why not just create and store a temp data file off the original until re-import or the client is closed?

@sivcan

This comment has been minimized.

Copy link
Member

commented Aug 2, 2018

Thanks for the suggestion. We'll keep a note of this.
We'll update the main thread once we have an update regarding the data file paths. :)

@vdespa

This comment has been minimized.

Copy link

commented Mar 12, 2019

The way this currently works is very confusing and frustrating.

@sivcan If a timely fix is not possible or too complicated, at least disable the "Retry" button after selecting a data file. Otherwise, it can be very confusing.

And why exactly was this issue closed?

@bonjour-anuj

This comment has been minimized.

Copy link

commented Apr 30, 2019

@sivcan The issue was reported last year in July. The latest version 7.0.9 still has the issue.
Can we know expected resolution date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.