Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added request setting to disable cookies #955

Merged
merged 1 commit into from Jan 13, 2020

Conversation

codenirvana
Copy link
Member

Added new protocolProfileBehavior property to disable cookie jar for an individual request.

@codenirvana codenirvana self-assigned this Jan 13, 2020
@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #955 into develop will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #955      +/-   ##
===========================================
+ Coverage    90.83%   90.89%   +0.06%     
===========================================
  Files           42       42              
  Lines         2378     2527     +149     
  Branches       670      750      +80     
===========================================
+ Hits          2160     2297     +137     
- Misses         218      230      +12
Flag Coverage Δ
#integration 80.6% <100%> (+0.66%) ⬆️
#legacy 59.12% <100%> (+0.83%) ⬆️
#unit 48.31% <100%> (+0.63%) ⬆️
Impacted Files Coverage Δ
lib/requester/core.js 89.66% <100%> (-1.87%) ⬇️
lib/runner/extensions/waterfall.command.js 93.75% <0%> (-0.08%) ⬇️
lib/runner/index.js 100% <0%> (ø) ⬆️
lib/requester/core-body-builder.js 98.94% <0%> (+0.43%) ⬆️
lib/authorizer/edgegrid.js 95% <0%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f55425...468b3c6. Read the comment docs.

@codenirvana codenirvana merged commit eef1ba5 into develop Jan 13, 2020
@codenirvana codenirvana deleted the feature/disable-cookies-setting branch January 13, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant