This repository has been archived by the owner. It is now read-only.

Move our red screen kernel patch to a Weston patch #1036

Open
PureTryOut opened this Issue Dec 23, 2017 · 6 comments

Comments

Projects
None yet
5 participants
@PureTryOut
Contributor

PureTryOut commented Dec 23, 2017

As reported by @bhush9, devices using the red screen kernel patch have a blue display if running kwin. This seems to be because we fix the red screen under Weston using a kernel patch, while it might be a Weston bug instead.

Can someone verify this?

@ollieparanoid

This comment has been minimized.

Show comment
Hide comment
@ollieparanoid

ollieparanoid Dec 23, 2017

Member

Thanks for making this issue. @bhush9 uses the lg-hammerhead, and PR #924 by @MartijnBraam disabled our weston workaround (deviceinfo_weston_pixman_type="2") in exchange for a kernel patch.

Now as I understood it, the kernel was reporting wrong information for the framebuffer driver and we fixed it that way. Is that wrong @bhush9?

Also @MartijnBraam, is it possible to run the X11 server without that kernel patch?

@bhush9: If it helps, here are instructions how to test the previous kernel without the patch:
Since we don't delete old packages yet, here is the binary package of the kernel that did not contain this patch. After pmbootstrap install, enter the device rootfs chroot with pmbootstrap chroot -r, download the package (e.g. with wget), then run apk add -u $package, which should downgrade it, and execute the initramfs trigger which then generates a new boot.img file. Run pmbootstrap export afterwards to get a symlink to the boot.img file, and copy it somewhere as pmbootstrap will recognize that the kernel package is outdated and try to update it again. fastboot boot $bootimg allows you to boot it.

Member

ollieparanoid commented Dec 23, 2017

Thanks for making this issue. @bhush9 uses the lg-hammerhead, and PR #924 by @MartijnBraam disabled our weston workaround (deviceinfo_weston_pixman_type="2") in exchange for a kernel patch.

Now as I understood it, the kernel was reporting wrong information for the framebuffer driver and we fixed it that way. Is that wrong @bhush9?

Also @MartijnBraam, is it possible to run the X11 server without that kernel patch?

@bhush9: If it helps, here are instructions how to test the previous kernel without the patch:
Since we don't delete old packages yet, here is the binary package of the kernel that did not contain this patch. After pmbootstrap install, enter the device rootfs chroot with pmbootstrap chroot -r, download the package (e.g. with wget), then run apk add -u $package, which should downgrade it, and execute the initramfs trigger which then generates a new boot.img file. Run pmbootstrap export afterwards to get a symlink to the boot.img file, and copy it somewhere as pmbootstrap will recognize that the kernel package is outdated and try to update it again. fastboot boot $bootimg allows you to boot it.

@MartijnBraam

This comment has been minimized.

Show comment
Hide comment
@MartijnBraam

MartijnBraam Dec 24, 2017

Member

X11 runs fine without the patch but it has the red tint on everything, in my case I also don't have a blue tint while running plasma-mobile

Member

MartijnBraam commented Dec 24, 2017

X11 runs fine without the patch but it has the red tint on everything, in my case I also don't have a blue tint while running plasma-mobile

@bhush9

This comment has been minimized.

Show comment
Hide comment
@bhush9

bhush9 Dec 25, 2017

Collaborator

You do,

See original screenshot (not from pmos)

Compare it with your picture, notable example being settings icon

img-20171224-wa0011

Collaborator

bhush9 commented Dec 25, 2017

You do,

See original screenshot (not from pmos)

Compare it with your picture, notable example being settings icon

img-20171224-wa0011

@MartijnBraam

This comment has been minimized.

Show comment
Hide comment
@MartijnBraam

MartijnBraam Dec 25, 2017

Member

Ah looks like the color channels are indeed swapped on my hammerhead, its just less visible as the big red haze with the red screen bug

Member

MartijnBraam commented Dec 25, 2017

Ah looks like the color channels are indeed swapped on my hammerhead, its just less visible as the big red haze with the red screen bug

@ollieparanoid ollieparanoid changed the title from Move our red screen kernel patch to a Weston patch to [hammerhead] Move our red screen kernel patch to a Weston patch Dec 25, 2017

@PureTryOut

This comment has been minimized.

Show comment
Hide comment
@PureTryOut

PureTryOut Dec 26, 2017

Contributor

This is not just a hammerhead thing though, multiple devices suffer from red screens and are using the kernel patch right now.

Contributor

PureTryOut commented Dec 26, 2017

This is not just a hammerhead thing though, multiple devices suffer from red screens and are using the kernel patch right now.

@ollieparanoid ollieparanoid changed the title from [hammerhead] Move our red screen kernel patch to a Weston patch to Move our red screen kernel patch to a Weston patch Dec 26, 2017

@rrooij

This comment has been minimized.

Show comment
Hide comment
@rrooij

rrooij Jan 5, 2018

Contributor

It is not always a Weston problem. My i9505 needed the kernel patch in order to get X even booting.

Contributor

rrooij commented Jan 5, 2018

It is not always a Weston problem. My i9505 needed the kernel patch in order to get X even booting.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.