This repository has been archived by the owner. It is now read-only.

Adding postmarketos-artwork #464

Closed
MartijnBraam opened this Issue Aug 25, 2017 · 15 comments

Comments

Projects
None yet
6 participants
@MartijnBraam
Member

MartijnBraam commented Aug 25, 2017

I guess we need a postmarketos-artwork package to provide default wallpapers for this distro

The *-artwork package name is based on how debian handles artwork for different distro variations, these packages provide a bunch of images in /usr/share (https://packages.debian.org/sid/all/debian-edu-artwork-lines/filelist)

I think we should provide wallpapers and a icon to be used for "start" buttons

Photo's that I made that can be used: http://imgur.com/a/73XW6 (I haven't added a licence to them yet, anyone knows what would be the best one?)

@PabloCastellano

This comment has been minimized.

Show comment
Hide comment
@PabloCastellano

PabloCastellano Aug 25, 2017

Member
Member

PabloCastellano commented Aug 25, 2017

@MartijnBraam

This comment has been minimized.

Show comment
Hide comment
@MartijnBraam

MartijnBraam Aug 25, 2017

Member

Here is a mint-style wallpaper created with blender

pmos

The blender source:
pmos.zip

Member

MartijnBraam commented Aug 25, 2017

Here is a mint-style wallpaper created with blender

pmos

The blender source:
pmos.zip

@MartijnBraam

This comment has been minimized.

Show comment
Hide comment
@MartijnBraam

MartijnBraam Aug 25, 2017

Member

I found the solution for the stem of the "p" when using the full name. Smallcaps:

postmarketos

Member

MartijnBraam commented Aug 25, 2017

I found the solution for the stem of the "p" when using the full name. Smallcaps:

postmarketos

@Jgjot-Singh

This comment has been minimized.

Show comment
Hide comment
@Jgjot-Singh

Jgjot-Singh Sep 3, 2017

I have some photos(my own work) that I'd like to make available. Should I just create an imgur gallery and link to it here?

Jgjot-Singh commented Sep 3, 2017

I have some photos(my own work) that I'd like to make available. Should I just create an imgur gallery and link to it here?

@MartijnBraam

This comment has been minimized.

Show comment
Hide comment
@MartijnBraam

MartijnBraam Sep 4, 2017

Member

We've moved the artwork to https://github.com/postmarketOS/artwork, you can create a PR there with your wallpapers

Member

MartijnBraam commented Sep 4, 2017

We've moved the artwork to https://github.com/postmarketOS/artwork, you can create a PR there with your wallpapers

@moondeck

This comment has been minimized.

Show comment
Hide comment
@moondeck

moondeck Jan 4, 2018

Contributor

I like the idea of a common package, but doesn't that require to either:

  1. Have individual packages for each DE (as they store wallpapers in different places)

  2. Have some sort of DE detection

or am i missing something?

Contributor

moondeck commented Jan 4, 2018

I like the idea of a common package, but doesn't that require to either:

  1. Have individual packages for each DE (as they store wallpapers in different places)

  2. Have some sort of DE detection

or am i missing something?

@PabloCastellano

This comment has been minimized.

Show comment
Hide comment
@PabloCastellano

PabloCastellano Jan 4, 2018

Member

I ignore if different DE have different locations for wallpapers. However for this case, we could achieve it this way:

  1. Create a postmarketos-artwork package that install the wallpapers to some location like /usr/share/wallpapers
  2. By using the install_if variable, copy or symlink the files to the proper location for the installed DE:
subpackages="$pkgname-artwork"
artwork() {
    install_if="$pkgname postmarketos-artwork"
    install -Dm644 /usr/share/wallpapers/01.png /path/to/DE/wallpapers/01.png
    install -Dm644 /usr/share/wallpapers/02.png /path/to/DE/wallpapers/02.png
}
Member

PabloCastellano commented Jan 4, 2018

I ignore if different DE have different locations for wallpapers. However for this case, we could achieve it this way:

  1. Create a postmarketos-artwork package that install the wallpapers to some location like /usr/share/wallpapers
  2. By using the install_if variable, copy or symlink the files to the proper location for the installed DE:
subpackages="$pkgname-artwork"
artwork() {
    install_if="$pkgname postmarketos-artwork"
    install -Dm644 /usr/share/wallpapers/01.png /path/to/DE/wallpapers/01.png
    install -Dm644 /usr/share/wallpapers/02.png /path/to/DE/wallpapers/02.png
}
@ollieparanoid

This comment has been minimized.

Show comment
Hide comment
@ollieparanoid

ollieparanoid Jan 5, 2018

Member

We have the postmarketos-ui-* packages, which handle postmarketOS configuration of the interfaces / desktop environments. I would recommend that we set the default wallpapers also in there instead of the install_if block.

Freedesktop.org has a specification where wallpapers should go:

DesktopThemeSpec:

Wallpapers should be installed in $XDG_DATA_DIRS/wallpapers

XDG Base Directory Specification

If $XDG_DATA_DIRS is either not set or empty, a value equal to /usr/local/share/:/usr/share/ should be used.

=> /usr/share/wallpapers seems to be the appropriate location.

Finally I recommend that we don't make the wallpaper/artwork package too big - it's probably good to make use of subpackages here, so people can only install the wallpapers they want to have and not a huge wallpaper pack that blows up the installation without using them. And we probably don't need to provide everything from the artwork repository in the packages (e.g. the reddit theme).

Member

ollieparanoid commented Jan 5, 2018

We have the postmarketos-ui-* packages, which handle postmarketOS configuration of the interfaces / desktop environments. I would recommend that we set the default wallpapers also in there instead of the install_if block.

Freedesktop.org has a specification where wallpapers should go:

DesktopThemeSpec:

Wallpapers should be installed in $XDG_DATA_DIRS/wallpapers

XDG Base Directory Specification

If $XDG_DATA_DIRS is either not set or empty, a value equal to /usr/local/share/:/usr/share/ should be used.

=> /usr/share/wallpapers seems to be the appropriate location.

Finally I recommend that we don't make the wallpaper/artwork package too big - it's probably good to make use of subpackages here, so people can only install the wallpapers they want to have and not a huge wallpaper pack that blows up the installation without using them. And we probably don't need to provide everything from the artwork repository in the packages (e.g. the reddit theme).

@moondeck

This comment has been minimized.

Show comment
Hide comment
@moondeck

moondeck Jan 5, 2018

Contributor

I will try to package that and submit a pull request then.

Contributor

moondeck commented Jan 5, 2018

I will try to package that and submit a pull request then.

@ollieparanoid

This comment has been minimized.

Show comment
Hide comment
@ollieparanoid

ollieparanoid Jan 5, 2018

Member

During research of the Freedesktop.org spec, I've found this page which lists where different desktop environments look for wallpapers (we could add a symlink to that path in the `postmarketos-ui-* package) and how to change them programmatically.

Member

ollieparanoid commented Jan 5, 2018

During research of the Freedesktop.org spec, I've found this page which lists where different desktop environments look for wallpapers (we could add a symlink to that path in the `postmarketos-ui-* package) and how to change them programmatically.

@MartijnBraam

This comment has been minimized.

Show comment
Hide comment
@MartijnBraam

MartijnBraam Jan 5, 2018

Member

Hmm the DE's I've used all read either /usr/share/wallpapers or /usr/share/backgrounds but that might just be my luck. Maybe create a postmarketos-artwork package with the wallpapers that literally say postmarketOS and a postmarketos-artwork-extra that contain all the nice-but-unbranded wallpapers since that will the the big bunch.

Member

MartijnBraam commented Jan 5, 2018

Hmm the DE's I've used all read either /usr/share/wallpapers or /usr/share/backgrounds but that might just be my luck. Maybe create a postmarketos-artwork package with the wallpapers that literally say postmarketOS and a postmarketos-artwork-extra that contain all the nice-but-unbranded wallpapers since that will the the big bunch.

@ollieparanoid

This comment has been minimized.

Show comment
Hide comment
@ollieparanoid

ollieparanoid Jan 5, 2018

Member

I like the idea, but "artwork" might be a bit too generic for wallpapers (what if we want to package ringtones etc. later?) - how about:

  • postmarketos-artwork (meta-package that depends on the subpackages)
  • postmarketos-artwork-wallpapers (the wallpapers saying pmOS or postmarketOS)
  • postmarketos-artwork-wallpapers-extra (the nice-but-unbranded wallpapers)
Member

ollieparanoid commented Jan 5, 2018

I like the idea, but "artwork" might be a bit too generic for wallpapers (what if we want to package ringtones etc. later?) - how about:

  • postmarketos-artwork (meta-package that depends on the subpackages)
  • postmarketos-artwork-wallpapers (the wallpapers saying pmOS or postmarketOS)
  • postmarketos-artwork-wallpapers-extra (the nice-but-unbranded wallpapers)
@moondeck

This comment has been minimized.

Show comment
Hide comment
@moondeck

moondeck Jan 5, 2018

Contributor

Sure, i'll do it like that. I don't know if its gonna be tomorrow or (european) sunday, but i will try to package that this weekend.

Contributor

moondeck commented Jan 5, 2018

Sure, i'll do it like that. I don't know if its gonna be tomorrow or (european) sunday, but i will try to package that this weekend.

@drebrez

This comment has been minimized.

Show comment
Hide comment
@drebrez

drebrez Feb 1, 2018

Member

@MartijnBraam now that the artwork has been packaged, this can be closed?

Member

drebrez commented Feb 1, 2018

@MartijnBraam now that the artwork has been packaged, this can be closed?

@MartijnBraam

This comment has been minimized.

Show comment
Hide comment
@MartijnBraam
Member

MartijnBraam commented Feb 26, 2018

Yep

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.