This repository has been archived by the owner. It is now read-only.

Artwork packages (corrected) #1097

Merged
merged 4 commits into from Jan 9, 2018

Conversation

Projects
None yet
4 participants
@moondeck
Contributor

moondeck commented Jan 7, 2018

Like #1096 but corrected (thanks to @MartijnBraam for guiding me through git)

@MartijnBraam MartijnBraam requested a review from ollieparanoid Jan 7, 2018

@ollieparanoid

I've added a few comments, and here are two more thoughts:

Thanks a lot for packaging this @moondeck!

Show outdated Hide outdated aports/main/postmarketos-artwork-wallpapers/APKBUILD Outdated
Show outdated Hide outdated aports/main/postmarketos-artwork-wallpapers-extra/APKBUILD Outdated
Show outdated Hide outdated aports/main/postmarketos-artwork-wallpapers/APKBUILD Outdated
Show outdated Hide outdated aports/main/postmarketos-artwork/APKBUILD Outdated
Show outdated Hide outdated aports/main/postmarketos-artwork-wallpapers-extra/APKBUILD Outdated
@moondeck

This comment has been minimized.

Show comment
Hide comment
@moondeck

moondeck Jan 8, 2018

Contributor

Terribly sorry for my bad "packaging", will correct it as soon as i have time, most likely tomorrow.

Contributor

moondeck commented Jan 8, 2018

Terribly sorry for my bad "packaging", will correct it as soon as i have time, most likely tomorrow.

@ollieparanoid

This comment has been minimized.

Show comment
Hide comment
@ollieparanoid

ollieparanoid Jan 8, 2018

Member

No need to be sorry, it was your first PR here! 😉

EDIT: okay, then "one of your first PRs" 😄

Member

ollieparanoid commented Jan 8, 2018

No need to be sorry, it was your first PR here! 😉

EDIT: okay, then "one of your first PRs" 😄

@moondeck

This comment has been minimized.

Show comment
Hide comment
@moondeck

moondeck Jan 8, 2018

Contributor

Hey, actually second! #1082 But yeah, i will correct it ASAP

Contributor

moondeck commented Jan 8, 2018

Hey, actually second! #1082 But yeah, i will correct it ASAP

moondeck added some commits Jan 9, 2018

@MartijnBraam

Looks good 👍

@MartijnBraam MartijnBraam merged commit ed813bc into postmarketOS:master Jan 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 64.525%
Details
extra() {
mkdir -p "$subpkgdir"/usr/share/wallpapers/
cp "$srcdir"/artwork-$_hash/wallpapers/extra/* \
"$subpkgdir"/usr/share/wallpapers/

This comment has been minimized.

@drebrez

drebrez Jan 9, 2018

Member

@moondeck as explained in chat, in APKBUILD we should use tabs, not spaces.

@drebrez

drebrez Jan 9, 2018

Member

@moondeck as explained in chat, in APKBUILD we should use tabs, not spaces.

This comment has been minimized.

@moondeck

moondeck Jan 9, 2018

Contributor

Weird, i've used "Tabify" on it (in Atom). I will submit a PR fixing that

@moondeck

moondeck Jan 9, 2018

Contributor

Weird, i've used "Tabify" on it (in Atom). I will submit a PR fixing that

PureTryOut added a commit that referenced this pull request Feb 21, 2018

Artwork packages (corrected) (#1097)
* Packaged wallpapers and added a postmarketos-artwork metapackage

* Added artwork packages

* Spaces -> Tabs

* Merged postmarketos-artwork-wallpapers-extra to be a subpackage
Corrected maintainer email
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.