Skip to content
This repository has been archived by the owner. It is now read-only.

Add initial support for Zenfone 5 (t00f/t00j) #1176

Merged
merged 3 commits into from Jan 29, 2018

Conversation

Projects
None yet
2 participants
@yxist
Copy link
Contributor

commented Jan 28, 2018

Current status:

  • flashing only manually (intel phones have different bootimg format)
  • usb networking works
  • xorg works using fbdev
  • packages needed for wayland are not available for x86
  • touch works in xorg and osk-sdl

yxist added some commits Jan 28, 2018

Add initial support for Zenfone 5 (t00f/t00j)
Current status:
  - flashing only manually (intel phones have different bootimg format)
  - usb networking works
  - xorg works using fbdev
  - packages needed for wayland are not available for x86
  - touch works in xorg and osk-sdl
@ollieparanoid
Copy link
Member

left a comment

Added two comments. From the dates in the patch files it looks like you have been working on this for a long time. So thank you very much for your hard work, and for finishing it and making the PR @yxist! 🎉

I can confirm that the kernel compiles successfully.

depends="linux-asus-t00f mkbootimg"
subpackages="$pkgname-x11"
source="
deviceinfo

This comment has been minimized.

Copy link
@ollieparanoid

ollieparanoid Jan 28, 2018

Member

We use tabs in APKBUILDs/shell scripts (just like Alpine) and spaces in Python. Could you adjust it in this APKBUILD?

package() {
install -Dm644 "$srcdir"/deviceinfo \
"$pkgdir"/etc/deviceinfo
install -Dm644 "$srcdir"/90-android-touch-dev.rules \

This comment has been minimized.

Copy link
@ollieparanoid

ollieparanoid Jan 28, 2018

Member

In newer device packages, we put the touch device in the deviceinfo and let devicepkg-dev generate the udev rule: https://wiki.postmarketos.org/wiki/Device_specific_package#devicepkg-dev
Could you please check if that works as well?

@yxist

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2018

Udev rule works. Everything builds and runs for me. I haven't been working on it for a long time, it was my main device back then, didn't want to brick it or something.

@ollieparanoid
Copy link
Member

left a comment

Thanks for making the changes!

One more request: it would be nice if you could create a device specific wiki page and add your device to the devices overview.

That way other Zenfone 5 owners could see your work, use it and improve it further.

@ollieparanoid ollieparanoid merged commit 8f099d3 into postmarketOS:master Jan 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.3%) to 66.419%
Details

@yxist yxist deleted the yxist:device/asus-t00f branch Feb 3, 2018

@yxist yxist restored the yxist:device/asus-t00f branch Feb 3, 2018

PureTryOut added a commit that referenced this pull request Feb 21, 2018

Add initial support for Zenfone 5 (t00f/t00j) (#1176)
Current status:
  - flashing only manually (intel phones have different bootimg format)
  - usb networking works
  - xorg works using fbdev
  - packages needed for wayland are not available for x86
  - touch works in xorg and osk-sdl
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.