Skip to content
This repository has been archived by the owner. It is now read-only.

New device: Moto G 4G (2013) #1264

Merged
merged 3 commits into from Feb 26, 2018

Conversation

Projects
None yet
4 participants
@pikpok
Copy link
Contributor

commented Feb 25, 2018

This device is very similar to falcon and titan, so most of the work here was just copy-paste.

As of now Weston with XWayland and WiFi, I've yet to try FDE.
XFCE and Hildon were two Xorg distros that I've tried and found not working (XFCE segfaults), but 06_fix_mdss_fb_rgb_mode.patch doesn't seem to fix the issue.

I also wanted to reuse firmware-motorola-titan package because those devices seem to share firmware - however, I needed one more file included in prima folder and I added it in this PR. I don't know if that's a good practice, or maybe package should be renamed to be more common, or should I move it to separate firmware package?

I will create wiki page describing port later.

Krzysztof Bezrąk added some commits Feb 25, 2018

Krzysztof Bezrąk
Krzysztof Bezrąk
@@ -0,0 +1,33 @@
source:

This comment has been minimized.

Copy link
@PureTryOut

PureTryOut Feb 25, 2018

Contributor

You seem to have this file twice, please remove this one.

@ollieparanoid
Copy link
Member

left a comment

@PureTryOut and I noted a few things that should be addressed in my opinion. When that is changed, and the wiki page is created and added to the "booting" table of the device overview, I think this is good to go!

Regarding the segfaults, if you're interested in debugging this together with us, I suggest opening a new issue with the logs you have. There is also an xorg-server-dbg package in Alpine, which you can use together with gdb to create a stack trace.

Thanks a lot for creating the port @pikpok! 🎉

license="MIT"
arch="noarch"
options="!check"
depends="linux-motorola-peregrine firmware-motorola-titan mkbootimg mesa-dri-swrast msm-fb-refresher"

This comment has been minimized.

Copy link
@ollieparanoid

ollieparanoid Feb 25, 2018

Member

Please add postmarketos-base to the depends, that is required now (that's why Travis is failing). For new generated device-* packages, this gets added automatically.

@@ -1,6 +1,6 @@
pkgname=firmware-motorola-titan
pkgver=1
pkgrel=0
pkgrel=1
pkgdesc="Firmware files for Motorola Moto G 2014 (titan)"

This comment has been minimized.

Copy link
@ollieparanoid

ollieparanoid Feb 25, 2018

Member

How about noting in the pkgdesc that this is also for the Moto G 4G now?

Other than that we don't have strict guidelines for the firmware packages yet, and I think it's fine to use the motorola-titan package in this case. Here it does not get blown up much by the additional file, and it saves us the redundancy of introducing another firmware package that has almost the same content.

@ollieparanoid
Copy link
Member

left a comment

Excellent, thanks again!

@ollieparanoid ollieparanoid merged commit d44776e into postmarketOS:master Feb 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.5%) to 75.643%
Details
@Sposito

This comment has been minimized.

Copy link

commented Mar 28, 2018

Hey I am trying here on mine it stucks on a black screen(mine is uk model), anybody else got it successful on peregrine?

@pikpok

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2018

Hi @Sposito, for me it was working fine, maybe try to ping me on Matrix/IRC and I'll try to help, closed PR isn't a good place for this IMHO 🙂 https://wiki.postmarketos.org/wiki/Matrix_and_IRC

@ollieparanoid

This comment has been minimized.

Copy link
Member

commented Mar 28, 2018

@Sposito: this was probably caused by #1364 (new version of mkfs.ext4 enabled a flag by default which some kernels couldn't handle), which is fixed now. If you pull the code from master and run the installation again, then it will probably work 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.