Skip to content
This repository has been archived by the owner. It is now read-only.

Add initial device support for Sony Xperia T3 (sony-seagull) #1389

Merged
merged 3 commits into from Apr 13, 2018

Conversation

Projects
None yet
3 participants
@MayeulC
Copy link
Contributor

commented Apr 3, 2018

The kernel is fetched from a sony copyleft archive, version 3.4.0.
Display, touch and USB networking are working.

In essence, this is reopening #1180
@PureTryOut convinced me to merge this as a starter, it only needed to be updated to the latest devicenfo format. I might still try to port a more recent kernel, but I don't have much time right now...

I am not sure I can mirror the archive on GitHub. It's 142MB, and doesn't fit in a "release" post. Will it fit in a depot?

@MayeulC MayeulC closed this Apr 3, 2018

@MayeulC MayeulC reopened this Apr 3, 2018

@MayeulC

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2018

Wow, there are some new fancy wiki checks!
Not sure why the CI failed, though...

@ollieparanoid

This comment has been minimized.

Copy link
Member

commented Apr 4, 2018

Thanks for making the PR! I didn't review it yet, but for here's a mirror of the source code:
https://github.com/pmsourcedump/android_kernel_sony_seagull
Also I'm not sure why Travis failed either (possibly the log was too long?) - I've kicked it off again.

@mirh

This comment has been minimized.

Copy link

commented Apr 4, 2018

Ehrm.. Didn't the tree I linked tickled?

@ollieparanoid
Copy link
Member

left a comment

Looks pretty good to me, only postmarketos-base is missing from depends (we require that now) and the source can be switched to the pmsourcedump repository.

@mirh: Thanks for suggesting a kernel. Does the other kernel have a significant advantage? TBH using the official sources from the vendor doesn't seem to be that bad here, because community maintained forks can introduce new bugs as well.

license="MIT"
arch="noarch"
options="!check"
depends="linux-sony-seagull mdss-fb-init-hack mkbootimg mesa-dri-swrast"

This comment has been minimized.

Copy link
@ollieparanoid

ollieparanoid Apr 4, 2018

Member

This is why Travis failed (in the second run, the log did not get cut off):

Missing 'postmarketos-base' in depends of /home/travis/build/postmarketOS/pmbootstrap/aports/device/device-sony-seagull/APKBUILD


# Source
_archive="18.1.A.1.23.tar.bz2"
_srcurl="https://dl.developer.sonymobile.com/code/copylefts/${_archive}"

This comment has been minimized.

Copy link
@ollieparanoid

ollieparanoid Apr 4, 2018

Member

The kernel of that big archive is mirrored to https://github.com/pmsourcedump/android_kernel_sony_seagull now.

@mirh

This comment has been minimized.

Copy link

commented Apr 5, 2018

I didn't link some random whatever kernel..
https://github.com/sonyxperiadev/kernel/tree/aosp/LA.BF64.1.2.2_rb4.7

In other news I found Yukon dts even on this quite newer branch https://github.com/sonyxperiadev/kernel/tree/aosp/LA.BR.1.3.3_rb2.14

@MayeulC

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2018

@mirh No, I didn't use this kernel for now. I looked into it, and even mainlining the device, but I was kind of busy lately, and I think that merging it with the vendor fork is better than not merging it at all.
I am still planning to work more on this. Actually, one of the reasons is that I am getting lost with all their tags on GitHub, and have no idea which kernels support my device; as I wasn't able to boot one.

@ollieparanoid: I don't know about using our own kernel repository. On one hand, people who use postmarketOS already rely on us for security, and "controlling" (still hosted on GitHub) the repository is better. On the other hand, fetching it from the official source seems more legit (and since the hash is the same, the replacement is easily verifiable). I could add the backup as a comment, or use it directly, which is what you would prefer, if I got it right?

@MayeulC MayeulC force-pushed the MayeulC:device/seagull branch from 640a109 to 322054c Apr 6, 2018

@mirh

This comment has been minimized.

Copy link

commented Apr 6, 2018

That's still downstream kernel tbh (so @opendata-like efforts would be needed to make "the big leap")
But the point would be anyway, that it's a way newer branch then what stock rom had. 3.10 instead of 3.4 is quite huge imo.

Anyway, enough said, it's all your choice in the end.

@ollieparanoid

This comment has been minimized.

Copy link
Member

commented Apr 8, 2018

@MayeulC: I would prefer downloading the source from our own mirror (assuming that you're not switching the kernel sources as you've said), so the download is smaller.

MayeulC added some commits Jan 29, 2018

Add initial device support for Sony Xperia T3 (sony-seagull)
The kernel is fetched from a sony copyleft archive, version 3.4.0.
Display, touch and USB networking are working.

@MayeulC MayeulC force-pushed the MayeulC:device/seagull branch from 322054c to 47922f4 Apr 12, 2018

@MayeulC

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2018

So, I'm back on this one -- on and off, sorry about that, I don't have much time these days.
@ollieparanoid Actually, I had another mirror here (I should add tags), but thought you wanted to retain the checksum compatibility. As for a big kernel bump, I am afraid this will have to wait.

@ollieparanoid
Copy link
Member

left a comment

Awesome work, thanks for getting back at this @MayeulC! 🎉
(Also no pressure, this is supposed to be a fun project 😉)

@ollieparanoid ollieparanoid merged commit a38c44b into postmarketOS:master Apr 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.6%) to 78.601%
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.