Skip to content
This repository has been archived by the owner. It is now read-only.

Don't run dhcpd on the raspberry pi #1580

Merged
merged 2 commits into from Jun 21, 2018

Conversation

Projects
None yet
3 participants
@ollieparanoid
Copy link
Member

commented Jun 19, 2018

Adds deviceinfo_disable_dhcpcd and sets it to true for the pi.

Related: #1547.

@PureTryOut: could you please review the few lines of code changes and test if the network problems go away with this PR?


[x] Merge on GitHub (see https://postmarketos.org/merge)

Don't run dhcpcd on the raspberry pi
Adds deviceinfo_disable_dhcpcd and sets it to true for the pi.

@ollieparanoid ollieparanoid force-pushed the feature/raspberry-pi-no-dhcpcd branch from 2b0e52e to 01bdd4f Jun 19, 2018

@PureTryOut
Copy link
Contributor

left a comment

This seems to have resolved the issue for me, although I still suffer from the insane packet loss both over ethernet and wifi.

@@ -241,6 +241,14 @@ start_udhcpd() {
# Only run once
[ -e /etc/udhcpd.conf ] && return

# Skip if disabled
# shellcheck disable=SC2154
if [ "$deviceinfo_disable_dhcpcd" = "true" ]; then

This comment has been minimized.

Copy link
@drebrez

drebrez Jun 20, 2018

Member

@ollieparanoid why dhcpcd ?
the function is called start_udhcpd, the config file udhcpd.conf and the executable udhcpd.
Why not calling the variable deviceinfo_disable_udhcpd?
I don't understand the cd suffix after dhcp.

This comment has been minimized.

Copy link
@drebrez

drebrez Jun 20, 2018

Member

From https://wiki.archlinux.org/index.php/dhcpcd:

dhcpcd => DHCP client daemon
dhcpd => DHCP (server) daemon
udhcpd => micro DHCP (server) daemon

with the variable we actually do 2 things:

  • do not set the static ip to the interface
  • do not start the DHCP (server) daemon

Don't know a better name for the variable but like this it might be confused with the DHCP client deamon which has nothing to do here.

This comment has been minimized.

Copy link
@ollieparanoid

ollieparanoid Jun 21, 2018

Author Member

Oh, the muscle memory of typing manually dhcpcd ... so often.

Thanks for catching that, I will change it to deviceinfo_disable_dhcpd, and describe the two things it does in the wiki description!

My reasoning for dhcpd instead of udhcpd is, because udhcpd is the implementation name of the busybox program. But the implementation name does not matter here, we might as well switch that out with another dhcp server if the udhcpd one doesn't behave like we want at some point (as it happened with busybox tar, which did unexpected things).

@ollieparanoid

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2018

@PureTryOut: thanks for testing!
@drebrez: thanks for the review, what do you think of the new version?

@ollieparanoid ollieparanoid merged commit e720858 into master Jun 21, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 77.926%
Details

@ollieparanoid ollieparanoid deleted the feature/raspberry-pi-no-dhcpcd branch Jun 21, 2018

@ollieparanoid ollieparanoid changed the title Don't run dhcpcd on the raspberry pi Don't run dhcpd on the raspberry pi Jun 21, 2018

postmarketOS-Wiki pushed a commit to postmarketOS/wiki that referenced this pull request Jun 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.