This repository has been archived by the owner. It is now read-only.

Add support for isorec flashing in recovery installer #609

Merged
merged 12 commits into from Sep 28, 2017

Conversation

Projects
None yet
3 participants
@ata2001
Member

ata2001 commented Sep 21, 2017

No description provided.

@ata2001 ata2001 requested a review from drebrez Sep 21, 2017

@ata2001

This comment has been minimized.

Show comment
Hide comment
@ata2001

ata2001 Sep 22, 2017

Member

Please test if you have a device with isorec (only at your own risk, read the diff beforehand)!

Member

ata2001 commented Sep 22, 2017

Please test if you have a device with isorec (only at your own risk, read the diff beforehand)!

ata2001 added some commits Sep 23, 2017

@drebrez

Tested on samsung-i9070 and everything works! Good job 👍

@ollieparanoid is it ok for you to have the pmb/flasher/variables.py script with the common function?

@ata2001 you should probably add the copyright note in the pmb/flasher/variables.py file

@ollieparanoid

This comment has been minimized.

Show comment
Hide comment
@ollieparanoid

ollieparanoid Sep 25, 2017

Member

@drebrez: I did not make a code review yet (will try to do that tomorrow), so I can't say what's my opinion on that. But in general I'm highly in favor of splitting code up in small files and functions where it makes sense.

Member

ollieparanoid commented Sep 25, 2017

@drebrez: I did not make a code review yet (will try to do that tomorrow), so I can't say what's my opinion on that. But in general I'm highly in favor of splitting code up in small files and functions where it makes sense.

@ollieparanoid

Code looks good to me! I agree with the missing copyright, and proposed a refactoring at one point.

(I don't really like vars["$..."] (the $ character!), but then I realized that your PR didn't introduce this and I wrote it that way myself :p - so that if we change that, it should be done in a new PR in my opinion.)

Thanks a lot for making this PR @ata2001!

Show outdated Hide outdated pmb/install/recovery.py
@ata2001

This comment has been minimized.

Show comment
Hide comment
@ata2001

ata2001 Sep 28, 2017

Member

@ollieparanoid Applied your patch, only has to change options.keys() to options.items().

Member

ata2001 commented Sep 28, 2017

@ollieparanoid Applied your patch, only has to change options.keys() to options.items().

@ata2001

This comment has been minimized.

Show comment
Hide comment
@ata2001

ata2001 Sep 28, 2017

Member

@ollieparanoid added license header

Member

ata2001 commented Sep 28, 2017

@ollieparanoid added license header

@ollieparanoid ollieparanoid merged commit 3cbd0d1 into master Sep 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ollieparanoid ollieparanoid deleted the feature/recovery-installer-isorec branch Sep 28, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.