This repository has been archived by the owner. It is now read-only.

Package unicsy_demo (basic hardware demo) #643

Merged
merged 8 commits into from Sep 29, 2017

Conversation

Projects
None yet
3 participants
@pavelmachek
Member

pavelmachek commented Sep 28, 2017

Create simple demo, that nevertheless demonstrates basic hardware functionality, including battery status, light sensor status, accelerometer status, LED control, control of backlight on keyboard and screen.

@ollieparanoid ollieparanoid changed the title from Hacks2 to Package unicsy_demo (basic hardware demo) Sep 28, 2017

@ollieparanoid

Thanks for packaging this!

Follow up questions:

  • How about adding a /usr/bin/unicsy_demo program, that launches the demo?
  • What does unicsy stand for?
  • How N900 specific is this package?
Show outdated Hide outdated aports/main/unicsy_demo/APKBUILD
Show outdated Hide outdated aports/main/unicsy_demo/APKBUILD
Show outdated Hide outdated aports/main/unicsy_demo/APKBUILD
Show outdated Hide outdated aports/main/unicsy_demo/APKBUILD
@pavelmachek

This comment has been minimized.

Show comment
Hide comment
@pavelmachek

pavelmachek Sep 28, 2017

Member
Member

pavelmachek commented Sep 28, 2017

@ollieparanoid

This comment has been minimized.

Show comment
Hide comment
@ollieparanoid

ollieparanoid Sep 28, 2017

Member

Thanks for the explanation and the fixes! I'm afraid the code isn't pushed yet though, because it does not show up here.

Member

ollieparanoid commented Sep 28, 2017

Thanks for the explanation and the fixes! I'm afraid the code isn't pushed yet though, because it does not show up here.

@pavelmachek

This comment has been minimized.

Show comment
Hide comment
@pavelmachek

pavelmachek Sep 28, 2017

Member
Member

pavelmachek commented Sep 28, 2017

@ollieparanoid

One small thing I've noticed. Also it might be good if someone tested this on a real device or in Qemu (I can't right now).

Show outdated Hide outdated aports/main/unicsy-demo/APKBUILD
@pavelmachek

This comment has been minimized.

Show comment
Hide comment
@pavelmachek

pavelmachek Sep 28, 2017

Member
Member

pavelmachek commented Sep 28, 2017

@drebrez

This comment has been minimized.

Show comment
Hide comment
@drebrez

drebrez Sep 29, 2017

Member

@ollieparanoid @pavelmachek I would like to test it on my devices, but I noticed some hardcoded paths in the hardware.py file (battery, leds,backlight,...).
We should consider adding those paths in some variables in the deviceinfo file of the device.

Member

drebrez commented Sep 29, 2017

@ollieparanoid @pavelmachek I would like to test it on my devices, but I noticed some hardcoded paths in the hardware.py file (battery, leds,backlight,...).
We should consider adding those paths in some variables in the deviceinfo file of the device.

@pavelmachek

This comment has been minimized.

Show comment
Hide comment
@pavelmachek

pavelmachek Sep 29, 2017

Member
Member

pavelmachek commented Sep 29, 2017

@pavelmachek

This comment has been minimized.

Show comment
Hide comment
@pavelmachek

pavelmachek Sep 29, 2017

Member
Member

pavelmachek commented Sep 29, 2017

@drebrez

This comment has been minimized.

Show comment
Hide comment
@drebrez

drebrez Sep 29, 2017

Member

@pavelmachek I agree that we don't need all the paths in variables, it's better if the tool tries to find it by itself.
I will try it on the various device I have (https://wiki.postmarketos.org/wiki/The-big-list-of-who-has-what-device#drebrez) and try to identify the paths that are different for each device.

Member

drebrez commented Sep 29, 2017

@pavelmachek I agree that we don't need all the paths in variables, it's better if the tool tries to find it by itself.
I will try it on the various device I have (https://wiki.postmarketos.org/wiki/The-big-list-of-who-has-what-device#drebrez) and try to identify the paths that are different for each device.

@ollieparanoid ollieparanoid merged commit ae1e527 into postmarketOS:master Sep 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ollieparanoid

This comment has been minimized.

Show comment
Hide comment
@ollieparanoid

ollieparanoid Sep 29, 2017

Member

Autodetection where possible, and using the deviceinfo otherwise sounds good to me! I've merged this PR so we have an initial version, that works on the N900 and recommend that we discuss how to implement support for different devices in the program's own issue tracker:

https://github.com/pavelmachek/unicsy_demo/issues

Thanks again!

Member

ollieparanoid commented Sep 29, 2017

Autodetection where possible, and using the deviceinfo otherwise sounds good to me! I've merged this PR so we have an initial version, that works on the N900 and recommend that we discuss how to implement support for different devices in the program's own issue tracker:

https://github.com/pavelmachek/unicsy_demo/issues

Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.